Changeset 45227

Timestamp:

04/17/2019 07:17:26 AM (6 years ago)

Author:

afercia

Message:

Accessibility: Make the Tags meta box better support Input Method Editor (IME) converters.

Also, restores the keyboard interaction behavior prior to [41988] by requesting one single Enter key press to add a tag.

Props ryanshoover, miyauchi.
Fixes #45371.

Location:

trunk/src/js/_enqueues/admin

Files:

• tags-box.js (modified) (2 diffs)
• tags-suggest.js (modified) (1 diff)

trunk/src/js/_enqueues/admin/tags-box.js

@@ -370 +370 @@
              * Handles pressing enter on the new tag input field.
              *
-             * Prevents submitting the post edit form.
+             * Prevents submitting the post edit form. Uses `keypress` to take
+             * into account Input Method Editor (IME) converters.
              *
              * @since 2.9.0
@@ -382 +383 @@
                     tagBox.userAction = 'add';
                     tagBox.flushTags( $( this ).closest( '.tagsdiv' ) );
-                    event.preventDefault();
-                    event.stopPropagation();
-                }
-            }).keypress( function( event ) {
-                if ( 13 == event.which ) {
                     event.preventDefault();
                     event.stopPropagation();

trunk/src/js/_enqueues/admin/tags-suggest.js

@@ -108 +108 @@
                     event.preventDefault();
                 } else if ( $.ui.keyCode.ENTER === event.keyCode ) {
+                    // If we're in the edit post Tags meta box, add the tag.
+                    if ( window.tagBox ) {
+                        window.tagBox.userAction = 'add';
+                        window.tagBox.flushTags( $( this ).closest( '.tagsdiv' ) );
+                    }
+
                     // Do not close Quick Edit / Bulk Edit
                     event.preventDefault();