Changeset 45235 for trunk/src/wp-includes/author-template.php

Timestamp:

04/17/2019 02:49:49 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Users: In wp_list_authors(), check for author's post count before getting author's metadata.

This significantly reduces the number of SQL queries when wp_list_authors() is called on a site where the majority of users don't have any posts, e.g. a membership site.

Props billerickson, ianbelanger, dswebsme.
Fixes #45105.

File:

• trunk/src/wp-includes/author-template.php (modified) (1 diff)

trunk/src/wp-includes/author-template.php

@@ -443 +443 @@
     }
     foreach ( $authors as $author_id ) {
+        $posts = isset( $author_count[ $author_id ] ) ? $author_count[ $author_id ] : 0;
+
+        if ( ! $posts && $args['hide_empty'] ) {
+            continue;
+        }
+
         $author = get_userdata( $author_id );
 
-        if ( $args['exclude_admin'] && 'admin' == $author->display_name ) {
-            continue;
-        }
-
-        $posts = isset( $author_count[ $author->ID ] ) ? $author_count[ $author->ID ] : 0;
-
-        if ( ! $posts && $args['hide_empty'] ) {
+        if ( $args['exclude_admin'] && 'admin' === $author->display_name ) {
             continue;
         }