Changeset 45247 for trunk/src/wp-includes/feed.php

Timestamp:

04/18/2019 05:07:07 PM (6 years ago)

Author:

adamsilverstein

Message:

Feeds: improve structure and naming of feed build date helper function.

Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming get_last_build_date to get_feed_build_date.

Props pento, spacedmonkey.
Fixes #4575.

File:

• trunk/src/wp-includes/feed.php (modified) (3 diffs)

trunk/src/wp-includes/feed.php

@@ -639 +639 @@
 
 /*
-* Get the timestamp of the most recently modified post from WP_Query.
-*
-* If viewing a comment feed, the date of the most recently modified
-* comment will be returned.
-*
-* @global WP_Query  $wp_query The global WP_Query object.
-*
-* @since 5.2.0
-*
-* @return string The timestamp.
-*/
-function get_last_build_date() {
+ * Get the timestamp of the most recently modified post from WP_Query.
+ *
+ * If viewing a comment feed, the timestamp of the most recently modified
+ * comment will be returned.
+ *
+ * @global WP_Query  $wp_query The global WP_Query object.
+ *
+ * @since 5.2.0
+ *
+ * @param string $format Format of the timestamp to return, passed to mysql2date.
+ *
+ * @return string The timestamp.
+ */
+function get_feed_build_date( $format ) {
     global $wp_query;
 
@@ -671 +673 @@
 
     // Determine the maximum modified time.
-    $max_modified_time = max( $modified_times );
+    $max_modified_time = max(
+        array_map(
+            function ( $time ) use ( $format ) {
+                return mysql2date( $format, $time, false );
+            },
+            $modified_times
+        )
+    );
 
     /**
@@ -678 +687 @@
      * @since 5.2.0
      *
-     * @param string $max_modified_times Date the last post or comment was modified in the query.
-     */
-    return apply_filters( 'get_last_build_date', $max_modified_time );
+     * @param string $max_modified_time Date the last post or comment was modified in the query.
+     * @param string $format            The date format requested in get_feed_build_date.
+     */
+    return apply_filters( 'get_feed_build_date', $max_modified_time, $format );
 }