Make WordPress Core


Ignore:
Timestamp:
04/18/2019 05:07:07 PM (6 years ago)
Author:
adamsilverstein
Message:

Feeds: improve structure and naming of feed build date helper function.

Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming get_last_build_date to get_feed_build_date.

Props pento, spacedmonkey.
Fixes #4575.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/feed/rss2.php

    r44951 r45247  
    473473     * @ticket 4575
    474474     *
    475      * @dataProvider data_test_get_last_build_date
    476      */
    477     public function test_get_last_build_date( $url, $element ) {
     475     * @dataProvider data_test_get_feed_build_date
     476     */
     477    public function test_get_feed_build_date( $url, $element ) {
    478478        $this->go_to( $url );
    479479        $feed = $this->do_rss2();
     
    483483        $rss             = xml_find( $xml, $element );
    484484        $last_build_date = $rss[0]['child'][0]['child'][4]['content'];
    485         $this->assertEquals( strtotime( get_last_build_date() ), strtotime( $last_build_date ) );
    486     }
    487 
    488 
    489     public function data_test_get_last_build_date() {
     485        $this->assertEquals( strtotime( get_feed_build_date( 'r' ) ), strtotime( $last_build_date ) );
     486    }
     487
     488
     489    public function data_test_get_feed_build_date() {
    490490        return array(
    491491            array( '/?feed=rss2', 'rss' ),
Note: See TracChangeset for help on using the changeset viewer.