Changeset 45259

Timestamp:

04/23/2019 09:04:19 PM (7 years ago)

Author:

azaozz

Message:

Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data.

Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-debug-data.php (modified) (2 diffs)
• site-health-info.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-debug-data.php

@@ -984 +984 @@
                  * for the copied data.
                  *
+                 * All strings are expected to be plain text except $description that can contain inline HTML tags (see below).
+                 *
                  * @since 5.2.0
                  *
@@ -995 +997 @@
                  *     @type string  $label        The title for this section of the debug output.
                  *     @type string  $description  Optional. A description for your information section which may contain basic HTML
-                 *                                 markup: `em`, `strong` and `a` for linking to documentation or putting emphasis.
+                 *                                 markup, inline tags only as it is outputted in a paragraph.
                  *     @type boolean $show_count   Optional. If set to `true` the amount of fields will be included in the title for
                  *                                 this section.

trunk/src/wp-admin/site-health-info.php

@@ -138 +138 @@
                                 <?php
 
-                                $kses_settings = array(
-                                        'a'      => array(
-                                                'href' => true,
-                                        ),
-                                        'strong' => true,
-                                        'em'     => true,
-                                );
-
                                 if ( isset( $details['description'] ) && ! empty( $details['description'] ) ) {
-                                        printf( '<p>%s</p>', wp_kses( $details['description'], $kses_settings ) );
+                                        printf( '<p>%s</p>', $details['description'] );
                                 }