Changeset 45275 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

05/01/2019 06:07:46 PM (6 years ago)

Author:

desrosj

Message:

Site Health: Disable recommendations that could be problematic on multisite installs.

When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.

For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.

This change also disables the test_wp_version_check_attached() test for multisite. This test checks for the presence of the wp_version_check() function on the wp_version_check hook, which is not present for every site on multisite.

Reviewed by jeremyfelt and desrosj.

Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -367 +367 @@
 
         // Check if there are inactive plugins.
-        if ( $plugins_total > $plugins_active ) {
+        if ( $plugins_total > $plugins_active && ! is_multisite() ) {
             $unused_plugins = $plugins_total - $plugins_active;
 
@@ -522 +522 @@
         }
 
-        if ( $has_unused_themes && $show_unused_themes ) {
+        if ( $has_unused_themes && $show_unused_themes && ! is_multisite() ) {
 
             // This is a child theme, so we want to be a bit more explicit in our messages.