Changeset 45276

Timestamp:

05/02/2019 10:36:02 AM (7 years ago)

Author:

desrosj

Message:

Help/About: Fix tab display issues.

This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.

Location:

trunk/src/wp-admin/css

Files:

• about.css (modified) (1 diff)
• colors/_admin.scss (modified) (1 diff)
• common.css (modified) (2 diffs)

trunk/src/wp-admin/css/about.css

@@ -112 +112 @@
         padding-left: 15px;
         font-size: 18px;
+        line-height: 1.33333333;
 }
 

trunk/src/wp-admin/css/colors/_admin.scss

@@ -131 +131 @@
 /* Active tabs use a bottom border color that matches the page background color. */
 
-.about-wrap h2 .nav-tab-active,
+.about-wrap .nav-tab-active,
 .nav-tab-active,
 .nav-tab-active:hover {

trunk/src/wp-admin/css/common.css

@@ -2172 +2172 @@
         padding: 5px 10px;
         font-size: 14px;
-        line-height: 1.8;
+        line-height: 1.71428571;
         font-weight: 600;
         background: #e5e5e5;
@@ -4000 +4000 @@
         h1 .nav-tab,
         h2 .nav-tab,
-        h3 .nav-tab {
+        h3 .nav-tab,
+        nav .nav-tab {
                 margin: 10px 10px 0 0;
+                border-bottom: 1px solid #ccc;
+        }
+
+        .nav-tab-active:hover,
+        .nav-tab-active:focus,
+        .nav-tab-active:focus:active {
                 border-bottom: 1px solid #ccc;
         }