Changeset 45285

Timestamp:

05/04/2019 08:59:11 PM (6 years ago)

Author:

azaozz

Message:

Fix setup_postdata() to set the (inside the loop) globals before the_post action is fired. Follow-up from #42814 and [44941].

Props david.binda, spacedmonkey, boonebgorges, birgire, jorbin, azaozz.
Fixes #47114 for trunk.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (2 diffs)
• tests/phpunit/tests/query/setupPostdata.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -4209 +4209 @@
         $numpages     = $elements['numpages'];
 
+        /**
+         * Fires once the post data has been setup.
+         *
+         * @since 2.8.0
+         * @since 4.1.0 Introduced `$this` parameter.
+         *
+         * @param WP_Post  $post The Post object (passed by reference).
+         * @param WP_Query $this The current Query object (passed by reference).
+         */
+        do_action_ref_array( 'the_post', array( &$post, &$this ) );
+
         return true;
     }
@@ -4299 +4310 @@
         }
 
-        /**
-         * Fires once the post data has been setup.
-         *
-         * @since 2.8.0
-         * @since 4.1.0 Introduced `$this` parameter.
-         *
-         * @param WP_Post  $post The Post object (passed by reference).
-         * @param WP_Query $this The current Query object (passed by reference).
-         */
-        do_action_ref_array( 'the_post', array( &$post, &$this ) );
-
         $elements = compact( 'id', 'authordata', 'currentday', 'currentmonth', 'page', 'pages', 'multipage', 'more', 'numpages' );
 

trunk/tests/phpunit/tests/query/setupPostdata.php

@@ -9 +9 @@
 
     protected $global_data = array();
+
+    protected $pages_global;
 
     public function setUp() {
@@ -417 +419 @@
     }
 
+    /**
+     * @ticket 47114
+     *
+     * setup_postdata() should set the globals before `the_post` action is fired.
+     */
+    public function test_the_post_action() {
+        $post = self::factory()->post->create_and_get();
+        add_action( 'the_post', array( $this, 'the_post_action_callback' ) );
+
+        setup_postdata( $post );
+
+        $this->assertEquals( $GLOBALS['pages'], $this->pages_global );
+    }
+
+    /**
+     * Helpers
+     */
+    public function the_post_action_callback() {
+        $this->pages_global = $GLOBALS['pages'];
+    }
 }