Changeset 45286 for branches/5.2/tests/phpunit/tests/query/setupPostdata.php

Timestamp:

05/04/2019 09:06:14 PM (7 years ago)

Author:

azaozz

Message:

Fix setup_postdata() to set the (inside the loop) globals before the_post action is fired. Follow-up from #42814 and [44941].

Props david.binda, spacedmonkey, boonebgorges, birgire, jorbin, azaozz.
Merges [45285] from trunk.
Fixes #47114 for 5.2.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/query/setupPostdata.php (modified) (2 diffs)

branches/5.2/tests/phpunit/tests/query/setupPostdata.php

@@ -9 +9 @@
 
     protected $global_data = array();
+
+    protected $pages_global;
 
     public function setUp() {
@@ -417 +419 @@
     }
 
+    /**
+     * @ticket 47114
+     *
+     * setup_postdata() should set the globals before `the_post` action is fired.
+     */
+    public function test_the_post_action() {
+        $post = self::factory()->post->create_and_get();
+        add_action( 'the_post', array( $this, 'the_post_action_callback' ) );
+
+        setup_postdata( $post );
+
+        $this->assertEquals( $GLOBALS['pages'], $this->pages_global );
+    }
+
+    /**
+     * Helpers
+     */
+    public function the_post_action_callback() {
+        $this->pages_global = $GLOBALS['pages'];
+    }
 }