Changeset 45309

Timestamp:

05/15/2019 02:24:15 PM (7 years ago)

Author:

desrosj

Message:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

Location:

trunk/src/wp-admin

Files:

• css/site-health.css (modified) (2 diffs)
• includes/class-wp-site-health.php (modified) (2 diffs)

trunk/src/wp-admin/css/site-health.css

@@ -154 +154 @@
 .health-check-body .good::before {
         content: "\f147";
-        display: inline-block;
         color: #46b450;
-        font-family: dashicons;
-        vertical-align: top;
 }
 
 .health-check-body .warning::before {
         content: "\f460";
-        display: inline-block;
         color: #ffb900;
-        font-family: dashicons;
 }
 
 .health-check-body .info::before {
         content: "\f348";
-        display: inline-block;
         color: #00a0d2;
-        font-family: dashicons;
 }
 
@@ -177 +170 @@
 .health-check-body .error::before {
         content: "\f335";
-        display: inline-block;
         color: #dc3232;
-        font-family: dashicons;
 }
 

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -890 +890 @@
                                 }
 
-                                $failures[ $library ] = "<span class='$class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
+                                $failures[ $library ] = "<span class='dashicons $class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
                         }
                 }
@@ -1488 +1488 @@
 
                         $output .= sprintf(
-                                '<li><span class="%s"><span class="screen-reader-text">%s</span></span> %s</li>',
+                                '<li><span class="dashicons %s"><span class="screen-reader-text">%s</span></span> %s</li>',
                                 esc_attr( $test->severity ),
                                 $severity_string,