WordPress.org

Make WordPress Core

Changeset 45314


Ignore:
Timestamp:
05/15/2019 07:51:20 PM (6 months ago)
Author:
desrosj
Message:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

Location:
branches/5.2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • branches/5.2

  • branches/5.2/src/wp-admin/css/site-health.css

    r45229 r45314  
    154154.health-check-body .good::before {
    155155    content: "\f147";
    156     display: inline-block;
    157156    color: #46b450;
    158     font-family: dashicons;
    159     vertical-align: top;
    160157}
    161158
    162159.health-check-body .warning::before {
    163160    content: "\f460";
    164     display: inline-block;
    165161    color: #ffb900;
    166     font-family: dashicons;
    167162}
    168163
    169164.health-check-body .info::before {
    170165    content: "\f348";
    171     display: inline-block;
    172166    color: #00a0d2;
    173     font-family: dashicons;
    174167}
    175168
     
    177170.health-check-body .error::before {
    178171    content: "\f335";
    179     display: inline-block;
    180172    color: #dc3232;
    181     font-family: dashicons;
    182173}
    183174
  • branches/5.2/src/wp-admin/includes/class-wp-site-health.php

    r45313 r45314  
    890890                }
    891891
    892                 $failures[ $library ] = "<span class='$class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
     892                $failures[ $library ] = "<span class='dashicons $class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
    893893            }
    894894        }
     
    14881488
    14891489            $output .= sprintf(
    1490                 '<li><span class="%s"><span class="screen-reader-text">%s</span></span> %s</li>',
     1490                '<li><span class="dashicons %s"><span class="screen-reader-text">%s</span></span> %s</li>',
    14911491                esc_attr( $test->severity ),
    14921492                $severity_string,
Note: See TracChangeset for help on using the changeset viewer.