Changeset 45331

Timestamp:

05/17/2019 12:06:49 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.

Props dimadin, SergeyBiryukov.
Fixes #47161.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -741 +741 @@
                 __( 'PHP modules perform most of the tasks on the server that make your site run. Any changes to these must be made by your server administrator.' ),
                 sprintf(
-                    /* translators: %s: Link to the hosting group page about recommended PHP modules. */
-                    __( 'The WordPress Hosting Team maintains a list of those modules, both recommended and required, in %s.' ),
+                    /* translators: 1: Link to the hosting group page about recommended PHP modules. 2: Additional link attributes. 3: Accessibility text. */
+                    __( 'The WordPress Hosting Team maintains a list of those modules, both recommended and required, in <a href="%1$s" %2$s>the team handbook %3$s</a>.' ),
+                    /* translators: Localized team handbook, if one exists. */
+                    esc_url( __( 'https://make.wordpress.org/hosting/handbook/handbook/server-environment/#php-extensions' ) ),
+                    'target="_blank" rel="noopener noreferrer"',
                     sprintf(
-                        '<a href="%1$s" target="_blank" rel="noopener noreferrer">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
-                        /* translators: Localized team handbook, if one exists. */
-                        esc_url( __( 'https://make.wordpress.org/hosting/handbook/handbook/server-environment/#php-extensions' ) ),
-                        __( 'the team handbook' ),
+                        '<span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span>',
                         /* translators: accessibility text */
                         __( '(opens in a new tab)' )