Changeset 45334 for trunk

Timestamp:

05/17/2019 12:52:32 AM (7 years ago)

Author:

SergeyBiryukov

Message:

I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].

Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Fixes #47159.

Location:

trunk/src

Files:

• wp-admin/includes/media.php (modified) (1 diff)
• wp-includes/media-template.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -3021 +3021 @@
                         <?php
                         printf(
-                                /* translators: 1: link start tag, 2: accessibility text, 3: link end tag */
-                                __( '%1$sDescribe the purpose of the image%2$s%3$s. Leave empty if the image is purely decorative.' ),
-                                '<a href="' . esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ) . '" target="_blank" rel="noopener noreferrer">',
+                                /* translators: 1: link to tutorial, 2: additional link attributes, 3: accessibility text */
+                                __( '<a href="%1$s" %2$s>Describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ),
+                                esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ),
+                                'target="_blank" rel="noopener noreferrer"',
                                 sprintf(
                                         '<span class="screen-reader-text"> %s</span>',
                                         /* translators: accessibility text */
                                         __( '(opens in a new tab)' )
-                                ),
-                                '</a>'
+                                )
                         );
                         ?>

trunk/src/wp-includes/media-template.php

@@ -164 +164 @@
 
         $alt_text_description = sprintf(
-                /* translators: 1: link start tag, 2: accessibility text, 3: link end tag */
-                __( '%1$sDescribe the purpose of the image%2$s%3$s. Leave empty if the image is purely decorative.' ),
-                '<a href="' . esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ) . '" target="_blank" rel="noopener noreferrer">',
+                /* translators: 1: link to tutorial, 2: additional link attributes, 3: accessibility text */
+                __( '<a href="%1$s" %2$s>Describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ),
+                esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ),
+                'target="_blank" rel="noopener noreferrer"',
                 sprintf(
                         '<span class="screen-reader-text"> %s</span>',
                         /* translators: accessibility text */
                         __( '(opens in a new tab)' )
-                ),
-                '</a>'
+                )
         );
         ?>