Changeset 45335 for branches/5.2/src/wp-includes/media-template.php

Timestamp:

05/17/2019 12:55:22 AM (6 years ago)

Author:

SergeyBiryukov

Message:

I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].

Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Merges [45334] to the 5.2 branch.
Fixes #47159.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-includes/media-template.php (modified) (1 diff)

branches/5.2/src/wp-includes/media-template.php

@@ -164 +164 @@
 
     $alt_text_description = sprintf(
-        /* translators: 1: link start tag, 2: accessibility text, 3: link end tag */
-        __( '%1$sDescribe the purpose of the image%2$s%3$s. Leave empty if the image is purely decorative.' ),
-        '<a href="' . esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ) . '" target="_blank" rel="noopener noreferrer">',
+        /* translators: 1: link to tutorial, 2: additional link attributes, 3: accessibility text */
+        __( '<a href="%1$s" %2$s>Describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ),
+        esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ),
+        'target="_blank" rel="noopener noreferrer"',
         sprintf(
             '<span class="screen-reader-text"> %s</span>',
             /* translators: accessibility text */
             __( '(opens in a new tab)' )
-        ),
-        '</a>'
+        )
     );
     ?>