Changeset 45365 for trunk/src/wp-admin/includes/update-core.php

Timestamp:

05/20/2019 02:28:03 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if wp_get_update_php_url() and wp_get_update_php_annotation() exist.

wp-admin/includes/update-core.php runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via function_exists().

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Fixes #47323.

File:

• trunk/src/wp-admin/includes/update-core.php (modified) (1 diff)

trunk/src/wp-admin/includes/update-core.php

@@ -947 +947 @@
     }
 
-    /* translators: %s: Update PHP page URL */
-    $php_update_message = '</p><p>' . sprintf( __( '<a href="%s">Learn more about updating PHP</a>.' ), esc_url( wp_get_update_php_url() ) );
-
-    $annotation = wp_get_update_php_annotation();
-    if ( $annotation ) {
-        $php_update_message .= '</p><p><em>' . $annotation . '</em>';
+    $php_update_message = '';
+    if ( function_exists( 'wp_get_update_php_url' ) ) {
+        /* translators: %s: Update PHP page URL */
+        $php_update_message = '</p><p>' . sprintf( __( '<a href="%s">Learn more about updating PHP</a>.' ), esc_url( wp_get_update_php_url() ) );
+
+        if ( function_exists( 'wp_get_update_php_annotation' ) ) {
+            $annotation = wp_get_update_php_annotation();
+            if ( $annotation ) {
+                $php_update_message .= '</p><p><em>' . $annotation . '</em>';
+            }
+        }
     }