Changeset 45368

Timestamp:

05/20/2019 02:46:35 PM (6 years ago)

Author:

desrosj

Message:

Feeds: Ensure a feed’s <lastBuildDate> has the correct date.

The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in max() is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].

Merges [45367] to the 5.2 branch.

Reviewed by desrosj, SergeyBiryukov.
Props onlanka, Rarst, mukesh27.
Fixes #47304.

Location:

branches/5.2

Files:

• . (modified) (1 prop)
• src/wp-includes/feed.php (modified) (1 diff)

branches/5.2/src/wp-includes/feed.php

@@ -673 +673 @@
 
     // Determine the maximum modified time.
-    $max_modified_time = max(
-        array_map(
-            function ( $time ) use ( $format ) {
-                return mysql2date( $format, $time, false );
-            },
-            $modified_times
-        )
-    );
+    $max_modified_time = mysql2date( $format, max( $modified_times ), false );
 
     /**