Changeset 45408

Timestamp:

05/25/2019 12:04:28 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Formatting: Don't run wp_targeted_link_rel() on entirely serialized content.

Props birgire, elliotcondon.
Fixes #46402.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (1 diff)
• tests/phpunit/tests/formatting/WPTargetedLinkRel.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -3041 +3041 @@
         // Don't run (more expensive) regex if no links with targets.
         if ( stripos( $text, 'target' ) !== false && stripos( $text, '<a ' ) !== false ) {
-                $text = preg_replace_callback( '|<a\s([^>]*target\s*=[^>]*)>|i', 'wp_targeted_link_rel_callback', $text );
+                if ( ! is_serialized( $text ) ) {
+                        $text = preg_replace_callback( '|<a\s([^>]*target\s*=[^>]*)>|i', 'wp_targeted_link_rel_callback', $text );
+                }
         }
 

trunk/tests/phpunit/tests/formatting/WPTargetedLinkRel.php

@@ -128 +128 @@
                 $this->assertEquals( $expected, wp_targeted_link_rel( $content ) );
         }
+
+        /**
+         * Ensure entirely serialized content is ignored.
+         *
+         * @ticket 46402.
+         */
+        public function test_ignore_entirely_serialized_content() {
+                $content  = 'a:1:{s:4:"html";s:52:"<p>Links: <a href="/" target="_blank">No Rel</a></p>";}';
+                $expected = 'a:1:{s:4:"html";s:52:"<p>Links: <a href="/" target="_blank">No Rel</a></p>";}';
+                $this->assertEquals( $expected, wp_targeted_link_rel( $content ) );
+        }
+
 }