Changeset 45416 for trunk/src/wp-admin/network/settings.php

Timestamp:

05/25/2019 03:18:24 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Improve settings tables and forms after [45403].

• adds role="presentation" to the edit comment table
• removes a few pointless <fieldset> elements
• adds a few missing <label> elements
• adds the CSS class class="td-full" to table rows spanning to multiple cells
• adds explicit scope="row" attribute to the table headers in options-permalink.php: this table is better communicated as data table
• uses consistent label association in the "Privacy Settings" page
• in the installation page "Set up your database connection": associates descriptions to their inout fields using aria-describedby
• improves the link to gravatar.com in the user-edit.php page

See #46899.
Fixes #47390.

File:

• trunk/src/wp-admin/network/settings.php (modified) (1 diff)

trunk/src/wp-admin/network/settings.php

@@ -453 +453 @@
              * @param string[] $admin_menus Associative array of the menu items available.
              */
-            $menu_items   = apply_filters( 'mu_menu_items', array( 'plugins' => __( 'Plugins' ) ) );
-            $fieldset_end = '';
-            if ( count( (array) $menu_items ) > 1 ) {
-                echo '<fieldset><legend class="screen-reader-text">' . __( 'Enable menus' ) . '</legend>';
-                $fieldset_end = '</fieldset>';
-            }
+            $menu_items = apply_filters( 'mu_menu_items', array( 'plugins' => __( 'Plugins' ) ) );
+
+            echo '<fieldset><legend class="screen-reader-text">' . __( 'Enable menus' ) . '</legend>';
+
             foreach ( (array) $menu_items as $key => $val ) {
                 echo "<label><input type='checkbox' name='menu_items[" . $key . "]' value='1'" . ( isset( $menu_perms[ $key ] ) ? checked( $menu_perms[ $key ], '1', false ) : '' ) . ' /> ' . esc_html( $val ) . '</label><br/>';
             }
-            echo $fieldset_end;
+
+            echo '</fieldset>';
             ?>
                 </td>