Changeset 45417

Timestamp:

05/25/2019 05:14:29 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Improve toggling the "Post locked" information visibility.

• effectively hides the "Post locked" information from assistive technologies
• when a post is locked, reveals the "Post locked" information without CSS animation
• the height CSS animation didn't work anyways after [24906]

See #24553.
Fixes #44946.

Location:

trunk/src

Files:

• js/_enqueues/admin/inline-edit-post.js (modified) (1 diff)
• wp-admin/css/list-tables.css (modified) (4 diffs)

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -530 +530 @@
             }
         } else if ( row.hasClass('wp-locked') ) {
-            // Make room for the CSS animation
-            row.removeClass('wp-locked').delay(1000).find('.locked-info span').empty();
+            row.removeClass( 'wp-locked' ).find( '.locked-info span' ).empty();
         }
     });

trunk/src/wp-admin/css/list-tables.css

@@ -538 +538 @@
 }
 
-tr.wp-locked .locked-indicator {
+.locked-indicator {
+    display: none;
     margin-left: 6px;
     height: 20px;
@@ -544 +545 @@
 }
 
-tr.wp-locked .locked-indicator-icon:before {
+.locked-indicator-icon:before {
     color: #82878c;
     content: "\f160";
@@ -555 +556 @@
 }
 
+.locked-info {
+    display: none;
+    margin-top: 4px;
+}
+
+.locked-text {
+    vertical-align: top;
+}
+
+.wp-locked .locked-indicator,
+.wp-locked .locked-info {
+    display: block;
+}
+
 tr.wp-locked .check-column label,
 tr.wp-locked .check-column input[type="checkbox"],
@@ -560 +575 @@
 tr.wp-locked .row-actions .trash {
     display: none;
-}
-
-tr .locked-info {
-    height: 0;
-    opacity: 0;
-}
-
-tr.wp-locked .locked-info {
-    margin-top: 4px;
-    height: auto;
-    opacity: 1;
-}
-
-.locked-text {
-    vertical-align: top;
-}
-
-tr.locked-info, tr.wp-locked .locked-info {
-    transition: height 1s, opacity 0.5s;
 }