Changeset 45424 for trunk/src/wp-includes/date.php

Timestamp:

05/26/2019 12:11:37 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Replace all instances of date() with gmdate().

Use of date() in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).

gmdate() is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.

Props nielsdeblaauw, Rarst.
Fixes #46438. See #44491.

File:

• trunk/src/wp-includes/date.php (modified) (3 diffs)

trunk/src/wp-includes/date.php

@@ -318 +318 @@
             }
 
-            $max_days_of_year = date( 'z', mktime( 0, 0, 0, 12, 31, $_year ) ) + 1;
+            $max_days_of_year = gmdate( 'z', mktime( 0, 0, 0, 12, 31, $_year ) ) + 1;
         } else {
             // otherwise we use the max of 366 (leap-year)
@@ -353 +353 @@
              * Note: the number of weeks in a year is the date in which Dec 28 appears.
              */
-            $week_count = date( 'W', mktime( 0, 0, 0, 12, 28, $_year ) );
+            $week_count = gmdate( 'W', mktime( 0, 0, 0, 12, 28, $_year ) );
 
         } else {
@@ -924 +924 @@
 
         if ( ! isset( $datetime['day'] ) ) {
-            $datetime['day'] = ( $default_to_max ) ? (int) date( 't', mktime( 0, 0, 0, $datetime['month'], 1, $datetime['year'] ) ) : 1;
+            $datetime['day'] = ( $default_to_max ) ? (int) gmdate( 't', mktime( 0, 0, 0, $datetime['month'], 1, $datetime['year'] ) ) : 1;
         }