Changeset 45424 for trunk/src/wp-includes/general-template.php

Timestamp:

05/26/2019 12:11:37 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Replace all instances of date() with gmdate().

Use of date() in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).

gmdate() is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.

Props nielsdeblaauw, Rarst.
Fixes #46438. See #44491.

File:

• trunk/src/wp-includes/general-template.php (modified) (7 diffs)

trunk/src/wp-includes/general-template.php

@@ -2108 +2108 @@
 
     $unixmonth = mktime( 0, 0, 0, $thismonth, 1, $thisyear );
-    $last_day  = date( 't', $unixmonth );
+    $last_day  = gmdate( 't', $unixmonth );
 
     // Get the next and previous month and year with at least one post
@@ -2134 +2134 @@
         $calendar_caption,
         $wp_locale->get_month( $thismonth ),
-        date( 'Y', $unixmonth )
+        gmdate( 'Y', $unixmonth )
     ) . '</caption>
     <thead>
@@ -2200 +2200 @@
 
     // See how much we should pad in the beginning
-    $pad = calendar_week_mod( date( 'w', $unixmonth ) - $week_begins );
+    $pad = calendar_week_mod( gmdate( 'w', $unixmonth ) - $week_begins );
     if ( 0 != $pad ) {
         $calendar_output .= "\n\t\t" . '<td colspan="' . esc_attr( $pad ) . '" class="pad">&nbsp;</td>';
@@ -2206 +2206 @@
 
     $newrow      = false;
-    $daysinmonth = (int) date( 't', $unixmonth );
+    $daysinmonth = (int) gmdate( 't', $unixmonth );
 
     for ( $day = 1; $day <= $daysinmonth; ++$day ) {
@@ -2224 +2224 @@
         if ( in_array( $day, $daywithpost ) ) {
             // any posts today?
-            $date_format = date( _x( 'F j, Y', 'daily archives date format' ), strtotime( "{$thisyear}-{$thismonth}-{$day}" ) );
+            $date_format = gmdate( _x( 'F j, Y', 'daily archives date format' ), strtotime( "{$thisyear}-{$thismonth}-{$day}" ) );
             /* translators: Post calendar label. %s: Date */
             $label            = sprintf( __( 'Posts published on %s' ), $date_format );
@@ -2238 +2238 @@
         $calendar_output .= '</td>';
 
-        if ( 6 == calendar_week_mod( date( 'w', mktime( 0, 0, 0, $thismonth, $day, $thisyear ) ) - $week_begins ) ) {
+        if ( 6 == calendar_week_mod( gmdate( 'w', mktime( 0, 0, 0, $thismonth, $day, $thisyear ) ) - $week_begins ) ) {
             $newrow = true;
         }
     }
 
-    $pad = 7 - calendar_week_mod( date( 'w', mktime( 0, 0, 0, $thismonth, $day, $thisyear ) ) - $week_begins );
+    $pad = 7 - calendar_week_mod( gmdate( 'w', mktime( 0, 0, 0, $thismonth, $day, $thisyear ) ) - $week_begins );
     if ( $pad != 0 && $pad != 7 ) {
         $calendar_output .= "\n\t\t" . '<td class="pad" colspan="' . esc_attr( $pad ) . '">&nbsp;</td>';
@@ -4453 +4453 @@
             break;
         case 'export':
-            $gen = '<!-- generator="WordPress/' . esc_attr( get_bloginfo_rss( 'version' ) ) . '" created="' . date( 'Y-m-d H:i' ) . '" -->';
+            $gen = '<!-- generator="WordPress/' . esc_attr( get_bloginfo_rss( 'version' ) ) . '" created="' . gmdate( 'Y-m-d H:i' ) . '" -->';
             break;
     }