Changeset 45424 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

05/26/2019 12:11:37 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Replace all instances of date() with gmdate().

Use of date() in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).

gmdate() is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.

Props nielsdeblaauw, Rarst.
Fixes #46438. See #44491.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (4 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -2950 +2950 @@
                         array(
                                 'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 50 ),
-                        )
-                );
-                $c2 = self::factory()->comment->create(
-                        array(
-                                'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 40 ),
-                        )
-                );
-                $c3 = self::factory()->comment->create(
-                        array(
-                                'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 30 ),
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 50 ),
+                        )
+                );
+                $c2 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 40 ),
+                        )
+                );
+                $c3 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 30 ),
                         )
                 );
@@ -2968 +2968 @@
                         array(
                                 'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 20 ),
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 20 ),
                         )
                 );
@@ -2996 +2996 @@
                         array(
                                 'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 50 ),
-                        )
-                );
-                $c2 = self::factory()->comment->create(
-                        array(
-                                'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 40 ),
-                        )
-                );
-                $c3 = self::factory()->comment->create(
-                        array(
-                                'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 30 ),
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 50 ),
+                        )
+                );
+                $c2 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 40 ),
+                        )
+                );
+                $c3 = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => self::$post_id,
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 30 ),
                         )
                 );
@@ -3014 +3014 @@
                         array(
                                 'comment_post_ID'  => self::$post_id,
-                                'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 20 ),
+                                'comment_date_gmt' => gmdate( 'Y-m-d H:i:s', $now - 20 ),
                         )
                 );