Changeset 45490

Timestamp:

06/04/2019 11:39:31 PM (7 years ago)

Author:

desrosj

Message:

Privacy: Remove inline CSS within personal data request list tables.

The .hidden class can be used to show and hide UI elements instead.

Props birgire, pratikthink, garrett-eclipse.
Fixes #44839.

Location:

trunk/src

Files:

• js/_enqueues/admin/privacy-tools.js (modified) (1 diff)
• wp-admin/includes/class-wp-privacy-data-export-requests-list-table.php (modified) (2 diffs)
• wp-admin/includes/class-wp-privacy-data-removal-requests-list-table.php (modified) (2 diffs)

trunk/src/js/_enqueues/admin/privacy-tools.js

@@ -10 +10 @@
 
         function setActionState( $action, state ) {
-                $action.children().hide();
-                $action.children( '.' + state ).show();
+                $action.children().addClass( 'hidden' );
+                $action.children( '.' + state ).removeClass( 'hidden' );
         }
 

trunk/src/wp-admin/includes/class-wp-privacy-data-export-requests-list-table.php

@@ -58 +58 @@
 
                 $download_data_markup .= '<span class="export-personal-data-idle"><button type="button" class="button-link export-personal-data-handle">' . __( 'Download Personal Data' ) . '</button></span>' .
-                        '<span style="display:none" class="export-personal-data-processing" >' . __( 'Downloading Data...' ) . '</span>' .
-                        '<span style="display:none" class="export-personal-data-success"><button type="button" class="button-link export-personal-data-handle">' . __( 'Download Personal Data Again' ) . '</button></span>' .
-                        '<span style="display:none" class="export-personal-data-failed">' . __( 'Download failed.' ) . ' <button type="button" class="button-link">' . __( 'Retry' ) . '</button></span>';
+                        '<span class="export-personal-data-processing hidden">' . __( 'Downloading Data...' ) . '</span>' .
+                        '<span class="export-personal-data-success hidden"><button type="button" class="button-link export-personal-data-handle">' . __( 'Download Personal Data Again' ) . '</button></span>' .
+                        '<span class="export-personal-data-failed hidden">' . __( 'Download failed.' ) . ' <button type="button" class="button-link">' . __( 'Retry' ) . '</button></span>';
 
                 $download_data_markup .= '</div>';
@@ -101 +101 @@
                                 ?>
                                 <span class="export-personal-data-idle"><button type="button" class="button export-personal-data-handle"><?php _e( 'Send Export Link' ); ?></button></span>
-                                <span style="display:none" class="export-personal-data-processing button updating-message" ><?php _e( 'Sending Email...' ); ?></span>
-                                <span style="display:none" class="export-personal-data-success success-message" ><?php _e( 'Email sent.' ); ?></span>
-                                <span style="display:none" class="export-personal-data-failed"><?php _e( 'Email could not be sent.' ); ?> <button type="button" class="button export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
+                                <span class="export-personal-data-processing button updating-message hidden"><?php _e( 'Sending Email...' ); ?></span>
+                                <span class="export-personal-data-success success-message hidden"><?php _e( 'Email sent.' ); ?></span>
+                                <span class="export-personal-data-failed hidden"><?php _e( 'Email could not be sent.' ); ?> <button type="button" class="button export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
                                 <?php
 

trunk/src/wp-admin/includes/class-wp-privacy-data-removal-requests-list-table.php

@@ -63 +63 @@
 
                         $remove_data_markup .= '<span class="remove-personal-data-idle"><button type="button" class="button-link remove-personal-data-handle">' . __( 'Force Erase Personal Data' ) . '</button></span>' .
-                                '<span style="display:none" class="remove-personal-data-processing" >' . __( 'Erasing Data...' ) . '</span>' .
-                                '<span style="display:none" class="remove-personal-data-failed">' . __( 'Force Erase has failed.' ) . ' <button type="button" class="button-link remove-personal-data-handle">' . __( 'Retry' ) . '</button></span>';
+                                '<span class="remove-personal-data-processing hidden">' . __( 'Erasing Data...' ) . '</span>' .
+                                '<span class="remove-personal-data-failed hidden">' . __( 'Force Erase has failed.' ) . ' <button type="button" class="button-link remove-personal-data-handle">' . __( 'Retry' ) . '</button></span>';
 
                         $remove_data_markup .= '</div>';
@@ -106 +106 @@
                                 ?>
                                 <span class="remove-personal-data-idle"><button type="button" class="button remove-personal-data-handle"><?php _e( 'Erase Personal Data' ); ?></button></span>
-                                <span style="display:none" class="remove-personal-data-processing button updating-message" ><?php _e( 'Erasing Data...' ); ?></span>
-                                <span style="display:none" class="remove-personal-data-failed"><?php _e( 'Erasing Data has failed.' ); ?> <button type="button" class="button remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
+                                <span class="remove-personal-data-processing button updating-message hidden"><?php _e( 'Erasing Data...' ); ?></span>
+                                <span class="remove-personal-data-failed hidden"><?php _e( 'Erasing Data has failed.' ); ?> <button type="button" class="button remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
                                 <?php