Changeset 45546

Timestamp:

06/18/2019 03:23:53 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Plugins: When validating plugin's WordPress and PHP requirements, check for Requires at least and Requires PHP headers in the plugin's main PHP file.

This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a readme.txt file.

If the headers are defined in both readme.txt and the main plugin file, precedence is given to the plugin file.

Props afragen, Otto42, Ipstenu.
Fixes #46938.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (6 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -32 +32 @@
  *          across all sites in an installation. This will prevent a plugin from being
  *          activated on a single site when Multisite is enabled.
+ *     Requires at least: Optional. Specify the minimum required WordPress version.
+ *     Requires PHP: Optional. Specify the minimum required PHP version.
  *      * / # Remove the space to close comment
  *
@@ -47 +49 @@
  *
  * @since 1.5.0
+ * @since 5.3.0 Added support for `Requires at least` and `Requires PHP`.
  *
  * @param string $plugin_file Absolute path to the main plugin file.
@@ -64 +67 @@
  *     @type string $DomainPath  Plugins relative directory path to .mo files.
  *     @type bool   $Network     Whether the plugin can only be activated network-wide.
+ *     @type string $RequiresWP  Minimum required version of WordPress.
+ *     @type string $RequiresPHP Minimum required version of PHP.
  * }
  */
@@ -78 +83 @@
         'DomainPath'  => 'Domain Path',
         'Network'     => 'Network',
+        'RequiresWP'  => 'Requires at least',
+        'RequiresPHP' => 'Requires PHP',
         // Site Wide Only is deprecated in favor of Network.
         '_sitewide'   => 'Site Wide Only',
@@ -1086 +1093 @@
 function validate_plugin_requirements( $plugin ) {
     $readme_file = WP_PLUGIN_DIR . '/' . dirname( $plugin ) . '/readme.txt';
+    $plugin_data = array(
+        'requires'     => '',
+        'requires_php' => '',
+    );
 
     if ( file_exists( $readme_file ) ) {
@@ -1096 +1107 @@
             'plugin'
         );
-    } else {
-        return true;
-    }
+    }
+
+    $plugin_data = array_merge( $plugin_data, get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin ) );
+
+    // Check for headers in the plugin's PHP file, give precedence to the plugin headers.
+    $plugin_data['requires']     = ! empty( $plugin_data['RequiresWP'] ) ? $plugin_data['RequiresWP'] : $plugin_data['requires'];
+    $plugin_data['requires_php'] = ! empty( $plugin_data['RequiresPHP'] ) ? $plugin_data['RequiresPHP'] : $plugin_data['requires_php'];
 
     $plugin_data['wp_compatible']  = is_wp_version_compatible( $plugin_data['requires'] );
     $plugin_data['php_compatible'] = is_php_version_compatible( $plugin_data['requires_php'] );
-
-    $plugin_data = array_merge( $plugin_data, get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin ) );
 
     if ( ! $plugin_data['wp_compatible'] && ! $plugin_data['php_compatible'] ) {