Changeset 45556

Timestamp:

06/20/2019 02:10:44 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Eliminate use of date_default_timezone_set() for determining DST status on General Options screen.

Time calculations should not need to rely on manipulating global PHP configuration state.

Props Rarst.
Fixes #46483.

File:

• trunk/src/wp-admin/options-general.php (modified) (2 diffs)

trunk/src/wp-admin/options-general.php

@@ -253 +253 @@
 <span>
     <?php
-    // Set TZ so localtime works.
-    date_default_timezone_set( $tzstring );
-    $now = localtime( time(), true );
-    if ( $now['tm_isdst'] ) {
+    $now = new DateTime( 'now', new DateTimeZone( $tzstring ) );
+    $dst = (bool) $now->format( 'I' );
+
+    if ( $dst ) {
         _e( 'This timezone is currently in daylight saving time.' );
     } else {
@@ -297 +297 @@
         }
     }
-    // Set back to UTC.
-    date_default_timezone_set( 'UTC' );
     ?>
     </span>