Changeset 45572 for trunk/src/wp-includes/media-template.php

Timestamp:

06/27/2019 12:32:28 PM (7 years ago)

Author:

afercia

Message:

Accessibility: Make the Media modal an ARIA modal dialog.

For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.

This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.

This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for aria-modal="true" improves.

Additionally:

• moves the modal H1 heading to the beginning of the modal content
• changes the modal left menu position to make visual and DOM order match
• improves the wp.media.view.FocusManager documentation

Fixes #47145.

File:

• trunk/src/wp-includes/media-template.php (modified) (2 diffs)

trunk/src/wp-includes/media-template.php

@@ -178 +178 @@
         <?php // Template for the media frame: used both in the media grid and in the media modal. ?>
         <script type="text/html" id="tmpl-media-frame">
+                <div class="media-frame-title" id="media-frame-title"></div>
                 <div class="media-frame-menu"></div>
-                <div class="media-frame-title"></div>
                 <div class="media-frame-router"></div>
                 <div class="media-frame-content"></div>
@@ -188 +188 @@
         <?php // Template for the media modal. ?>
         <script type="text/html" id="tmpl-media-modal">
-                <div tabindex="0" class="<?php echo $class; ?>">
+                <div tabindex="0" class="<?php echo $class; ?>" role="dialog" aria-modal="true" aria-labelledby="media-frame-title">
                         <# if ( data.hasCloseButton ) { #>
                                 <button type="button" class="media-modal-close"><span class="media-modal-icon"><span class="screen-reader-text"><?php _e( 'Close dialog' ); ?></span></span></button>
                         <# } #>
-                        <div class="media-modal-content"></div>
+                        <div class="media-modal-content" role="document"></div>
                 </div>
                 <div class="media-modal-backdrop"></div>