Changeset 45573

Timestamp:

06/28/2019 06:43:27 AM (6 years ago)

Author:

pento

Message:

Formatting: Add support for seconds to human_time_diff().

The web has gotten so much faster since human_time_diff() was created, we need to be able to measure time differences with much finer granularity. Now, we can.

Props johnjamesjacoby, pento.
Fixes #35655.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (2 diffs)
• tests/phpunit/tests/formatting/HumanTimeDiff.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -3609 +3609 @@
  *
  * @since 1.5.0
+ * @since 5.3.0 Added support for showing a difference in seconds.
  *
  * @param int $from Unix timestamp from which the difference begins.
@@ -3621 +3622 @@
     $diff = (int) abs( $to - $from );
 
-    if ( $diff < HOUR_IN_SECONDS ) {
+    if ( $diff < MINUTE_IN_SECONDS ) {
+        $secs = $diff;
+        if ( $secs <= 1 ) {
+            $secs = 1;
+        }
+        /* translators: Time difference between two dates, in seconds. %s: Number of seconds */
+        $since = sprintf( _n( '%s second', '%s seconds', $secs ), $secs );
+    } elseif ( $diff < HOUR_IN_SECONDS && $diff >= MINUTE_IN_SECONDS ) {
         $mins = round( $diff / MINUTE_IN_SECONDS );
         if ( $mins <= 1 ) {

trunk/tests/phpunit/tests/formatting/HumanTimeDiff.php

@@ -20 +20 @@
     function data_test_human_time_diff() {
         return array(
+            array(
+                '37 seconds',
+                new DateTime( '2016-01-01 12:00:37' ),
+                'Test a difference of 37 seconds.',
+            ),
             array(
                 '5 mins',