Changeset 45578

Timestamp:

07/01/2019 03:28:21 AM (5 years ago)

Author:

pento

Message:

Formatting: Trim leading whitespace in esc_url().

Props toszcze.
Fixes #36369.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (1 diff)
• tests/phpunit/tests/formatting/EscUrl.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -4203 +4203 @@
     }
 
-    $url = str_replace( ' ', '%20', $url );
+    $url = str_replace( ' ', '%20', ltrim( $url ) );
     $url = preg_replace( '|[^a-z0-9-~+_.?#=!&;,/:%@$\|*\'()\[\]\\x80-\\xff]|i', '', $url );
 

trunk/tests/phpunit/tests/formatting/EscUrl.php

@@ -14 +14 @@
         $this->assertEquals( 'http://example.com/Mr%20%20WordPress', esc_url( 'http://example.com/Mr%20%20WordPress' ) );
         $this->assertEquals( 'http://example.com/Mr+WordPress', esc_url( 'http://example.com/Mr+WordPress' ) );
+        $this->assertEquals( 'http://example.com/Mr+WordPress', esc_url( ' http://example.com/Mr+WordPress' ) );
 
         $this->assertEquals( 'http://example.com/?foo=one%20two%20three&bar=four', esc_url( 'http://example.com/?foo=one two three&bar=four' ) );