Changeset 45581 for trunk/src/wp-content/themes/twentyten/header.php

Timestamp:

07/01/2019 08:22:31 AM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in the default themes.

See #47632

File:

• trunk/src/wp-content/themes/twentyten/header.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyten/header.php

@@ -86 +86 @@
                 }
 
-                    // Check if this is a post or page, if it has a thumbnail, and if it's a big one
-                if ( is_singular() && current_theme_supports( 'post-thumbnails' ) &&
-                            has_post_thumbnail( $post->ID ) &&
-                            ( /* $src, $width, $height */ $image = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'post-thumbnail' ) ) &&
-                            $image[1] >= $header_image_width ) :
-                    // Houston, we have a new header image!
-                    echo get_the_post_thumbnail( $post->ID );
-                    elseif ( get_header_image() ) :
-                        // Compatibility with versions of WordPress prior to 3.4.
-                        if ( function_exists( 'get_custom_header' ) ) {
-                            $header_image_width  = get_custom_header()->width;
-                            $header_image_height = get_custom_header()->height;
-                        } else {
-                            $header_image_width  = HEADER_IMAGE_WIDTH;
-                            $header_image_height = HEADER_IMAGE_HEIGHT;
-                        }
-                        ?>
-                        <img src="<?php header_image(); ?>" width="<?php echo esc_attr( $header_image_width ); ?>" height="<?php echo esc_attr( $header_image_height ); ?>" alt="" />
-                    <?php endif; ?>
+                // Check if this is a post or page, if it has a thumbnail, and if it's a big one
+                if ( is_singular() && has_post_thumbnail( $post->ID ) ) {
+                    $image = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), array( $header_image_width, $header_image_width ) );
+                    if ( $image && $image[1] >= $header_image_width ) {
+                        // Houston, we have a new header image!
+                        echo get_the_post_thumbnail( $post->ID, 'post-thumbnail' );
+                    }
+                } else {
+                    // Compatibility with versions of WordPress prior to 3.4.
+                    if ( function_exists( 'get_custom_header' ) ) {
+                        $header_image_width  = get_custom_header()->width;
+                        $header_image_height = get_custom_header()->height;
+                    } else {
+                        $header_image_width  = HEADER_IMAGE_WIDTH;
+                        $header_image_height = HEADER_IMAGE_HEIGHT;
+                    }
+                    ?>
+                    <img src="<?php header_image(); ?>" width="<?php echo esc_attr( $header_image_width ); ?>" height="<?php echo esc_attr( $header_image_height ); ?>" alt="" />
+                    <?php
+                } // end check for featured image or standard header
+                ?>
             </div><!-- #branding -->