Changeset 45583 for trunk/src/wp-admin/includes/misc.php

Timestamp:

07/01/2019 12:50:14 PM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin.

See #47632.

File:

• trunk/src/wp-admin/includes/misc.php (modified) (7 diffs)

trunk/src/wp-admin/includes/misc.php

@@ -137 +137 @@
 
     // Split out the existing file into the preceding lines, and those that appear after the marker
-    $pre_lines    = $post_lines = $existing_lines = array();
-    $found_marker = $found_end_marker = false;
+    $pre_lines        = array();
+    $post_lines       = array();
+    $existing_lines   = array();
+    $found_marker     = false;
+    $found_end_marker = false;
     foreach ( $lines as $line ) {
         if ( ! $found_marker && false !== strpos( $line, $start_marker ) ) {
@@ -597 +600 @@
         check_admin_referer( 'screen-options-nonce', 'screenoptionnonce' );
 
-        if ( ! $user = wp_get_current_user() ) {
+        $user = wp_get_current_user();
+        if ( ! $user ) {
             return;
         }
@@ -965 +969 @@
     if ( array_key_exists( 'wp-check-locked-posts', $data ) && is_array( $data['wp-check-locked-posts'] ) ) {
         foreach ( $data['wp-check-locked-posts'] as $key ) {
-            if ( ! $post_id = absint( substr( $key, 5 ) ) ) {
+            $post_id = absint( substr( $key, 5 ) );
+            if ( ! $post_id ) {
                 continue;
             }
 
-            if ( ( $user_id = wp_check_post_lock( $post_id ) ) && ( $user = get_userdata( $user_id ) ) && current_user_can( 'edit_post', $post_id ) ) {
-                $send = array( 'text' => sprintf( __( '%s is currently editing' ), $user->display_name ) );
-
-                if ( ( $avatar = get_avatar( $user->ID, 18 ) ) && preg_match( "|src='([^']+)'|", $avatar, $matches ) ) {
-                    $send['avatar_src'] = $matches[1];
+            $user_id = wp_check_post_lock( $post_id );
+            if ( $user_id ) {
+                $user = get_userdata( $user_id );
+                if ( $user && current_user_can( 'edit_post', $post_id ) ) {
+                    $send = array( 'text' => sprintf( __( '%s is currently editing' ), $user->display_name ) );
+
+                    $avatar = get_avatar( $user->ID, 18 );
+                    if ( $avatar && preg_match( "|src='([^']+)'|", $avatar, $matches ) ) {
+                        $send['avatar_src'] = $matches[1];
+                    }
+
+                    $checked[ $key ] = $send;
                 }
-
-                $checked[ $key ] = $send;
             }
         }
@@ -1003 +1013 @@
         $send     = array();
 
-        if ( ! $post_id = absint( $received['post_id'] ) ) {
+        $post_id = absint( $received['post_id'] );
+        if ( ! $post_id ) {
             return $response;
         }
@@ -1011 +1022 @@
         }
 
-        if ( ( $user_id = wp_check_post_lock( $post_id ) ) && ( $user = get_userdata( $user_id ) ) ) {
+        $user_id = wp_check_post_lock( $post_id );
+        $user    = get_userdata( $user_id );
+        if ( $user ) {
             $error = array(
                 'text' => sprintf( __( '%s has taken over and is currently editing.' ), $user->display_name ),
             );
 
-            if ( $avatar = get_avatar( $user->ID, 64 ) ) {
+            $avatar = get_avatar( $user->ID, 64 );
+            if ( $avatar ) {
                 if ( preg_match( "|src='([^']+)'|", $avatar, $matches ) ) {
                     $error['avatar_src'] = $matches[1];
@@ -1024 +1038 @@
             $send['lock_error'] = $error;
         } else {
-            if ( $new_lock = wp_set_post_lock( $post_id ) ) {
+            $new_lock = wp_set_post_lock( $post_id );
+            if ( $new_lock ) {
                 $send['new_lock'] = implode( ':', $new_lock );
             }
@@ -1050 +1065 @@
         $response['wp-refresh-post-nonces'] = array( 'check' => 1 );
 
-        if ( ! $post_id = absint( $received['post_id'] ) ) {
+        $post_id = absint( $received['post_id'] );
+        if ( ! $post_id ) {
             return $response;
         }