Changeset 45583 for trunk/src/wp-admin/includes/post.php

Timestamp:

07/01/2019 12:50:14 PM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin.

See #47632.

File:

• trunk/src/wp-admin/includes/post.php (modified) (12 diffs)

trunk/src/wp-admin/includes/post.php

@@ -340 +340 @@
         if ( isset( $post_data['meta'] ) && $post_data['meta'] ) {
                 foreach ( $post_data['meta'] as $key => $value ) {
-                        if ( ! $meta = get_post_meta_by_id( $key ) ) {
+                        $meta = get_post_meta_by_id( $key );
+                        if ( ! $meta ) {
                                 continue;
                         }
@@ -358 +359 @@
         if ( isset( $post_data['deletemeta'] ) && $post_data['deletemeta'] ) {
                 foreach ( $post_data['deletemeta'] as $key => $value ) {
-                        if ( ! $meta = get_post_meta_by_id( $key ) ) {
+                        $meta = get_post_meta_by_id( $key );
+                        if ( ! $meta ) {
                                 continue;
                         }
@@ -532 +534 @@
         }
 
-        if ( isset( $post_data['post_parent'] ) && ( $parent = (int) $post_data['post_parent'] ) ) {
+        if ( isset( $post_data['post_parent'] ) && (int) $post_data['post_parent'] ) {
+                $parent   = (int) $post_data['post_parent'];
                 $pages    = $wpdb->get_results( "SELECT ID, post_parent FROM $wpdb->posts WHERE post_type = 'page'" );
                 $children = array();
@@ -548 +551 @@
         }
 
-        $updated          = $skipped = $locked = array();
+        $updated          = array();
+        $skipped          = array();
+        $locked           = array();
         $shared_post_data = $post_data;
 
@@ -1282 +1287 @@
         if ( isset( $_GET['edit'] ) && $_GET['edit'] == $box_id ) {
                 $classes = array( '' );
-        } elseif ( $closed = get_user_option( 'closedpostboxes_' . $screen_id ) ) {
+        } elseif ( get_user_option( 'closedpostboxes_' . $screen_id ) ) {
+                $closed = get_user_option( 'closedpostboxes_' . $screen_id );
                 if ( ! is_array( $closed ) ) {
                         $classes = array( '' );
@@ -1557 +1563 @@
  */
 function wp_check_post_lock( $post_id ) {
-        if ( ! $post = get_post( $post_id ) ) {
+        $post = get_post( $post_id );
+        if ( ! $post ) {
                 return false;
         }
 
-        if ( ! $lock = get_post_meta( $post->ID, '_edit_lock', true ) ) {
+        $lock = get_post_meta( $post->ID, '_edit_lock', true );
+        if ( ! $lock ) {
                 return false;
         }
@@ -1593 +1601 @@
  */
 function wp_set_post_lock( $post_id ) {
-        if ( ! $post = get_post( $post_id ) ) {
+        $post = get_post( $post_id );
+        if ( ! $post ) {
                 return false;
         }
 
-        if ( 0 == ( $user_id = get_current_user_id() ) ) {
+        $user_id = get_current_user_id();
+        if ( 0 == $user_id ) {
                 return false;
         }
@@ -1616 +1626 @@
  */
 function _admin_notice_post_locked() {
-        if ( ! $post = get_post() ) {
+        $post = get_post();
+        if ( ! $post ) {
                 return;
         }
 
-        $user = null;
-        if ( $user_id = wp_check_post_lock( $post->ID ) ) {
+        $user    = null;
+        $user_id = wp_check_post_lock( $post->ID );
+        if ( $user_id ) {
                 $user = get_userdata( $user_id );
         }
@@ -1647 +1659 @@
         }
 
-        if ( $locked && ( $sendback = wp_get_referer() ) &&
-                false === strpos( $sendback, 'post.php' ) && false === strpos( $sendback, 'post-new.php' ) ) {
+        $sendback = wp_get_referer();
+        if ( $locked && $sendback && false === strpos( $sendback, 'post.php' ) && false === strpos( $sendback, 'post-new.php' ) ) {
 
                 $sendback_text = __( 'Go back' );
@@ -1794 +1806 @@
 
         // Store one autosave per author. If there is already an autosave, overwrite it.
-        if ( $old_autosave = wp_get_post_autosave( $post_id, $post_author ) ) {
+        $old_autosave = wp_get_post_autosave( $post_id, $post_author );
+        if ( $old_autosave ) {
                 $new_autosave                = _wp_post_revision_data( $post_data, true );
                 $new_autosave['ID']          = $old_autosave->ID;
@@ -1845 +1858 @@
         $_POST['ID'] = $post_ID;
 
-        if ( ! $post = get_post( $post_ID ) ) {
+        $post = get_post( $post_ID );
+        if ( ! $post ) {
                 wp_die( __( 'Sorry, you are not allowed to edit this post.' ) );
         }
@@ -1906 +1920 @@
         }
 
-        $post_id         = (int) $post_data['post_id'];
-        $post_data['ID'] = $post_data['post_ID'] = $post_id;
+        $post_id              = (int) $post_data['post_id'];
+        $post_data['ID']      = $post_id;
+        $post_data['post_ID'] = $post_id;
 
         if ( false === wp_verify_nonce( $post_data['_wpnonce'], 'update-post_' . $post_id ) ) {