Changeset 45590 for trunk/src/wp-includes/admin-bar.php

Timestamp:

07/02/2019 11:41:16 PM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.

See #47632.

File:

• trunk/src/wp-includes/admin-bar.php (modified) (4 diffs)

trunk/src/wp-includes/admin-bar.php

@@ -689 +689 @@
         $current_screen = get_current_screen();
         $post           = get_post();
+        if ( 'post' == $current_screen->base ) {
+            $post_type_object = get_post_type_object( $post->post_type );
+        } elseif ( 'edit' == $current_screen->base ) {
+            $post_type_object = get_post_type_object( $current_screen->post_type );
+        }
 
         if ( 'post' == $current_screen->base
             && 'add' != $current_screen->action
-            && ( $post_type_object = get_post_type_object( $post->post_type ) )
+            && ( $post_type_object )
             && current_user_can( 'read_post', $post->ID )
             && ( $post_type_object->public )
@@ -716 +721 @@
             }
         } elseif ( 'edit' == $current_screen->base
-            && ( $post_type_object = get_post_type_object( $current_screen->post_type ) )
+            && ( $post_type_object )
             && ( $post_type_object->public )
             && ( $post_type_object->show_in_admin_bar )
@@ -728 +733 @@
                 )
             );
-        } elseif ( 'term' == $current_screen->base
-            && isset( $tag ) && is_object( $tag ) && ! is_wp_error( $tag )
-            && ( $tax = get_taxonomy( $tag->taxonomy ) )
-            && is_taxonomy_viewable( $tax ) ) {
-            $wp_admin_bar->add_menu(
-                array(
-                    'id'    => 'view',
-                    'title' => $tax->labels->view_item,
-                    'href'  => get_term_link( $tag ),
-                )
-            );
-        } elseif ( 'user-edit' == $current_screen->base
-            && isset( $user_id )
-            && ( $user_object = get_userdata( $user_id ) )
-            && $user_object->exists()
-            && $view_link = get_author_posts_url( $user_object->ID ) ) {
-            $wp_admin_bar->add_menu(
-                array(
-                    'id'    => 'view',
-                    'title' => __( 'View User' ),
-                    'href'  => $view_link,
-                )
-            );
+        } elseif ( 'term' == $current_screen->base && isset( $tag ) && is_object( $tag ) && ! is_wp_error( $tag ) ) {
+            $tax = get_taxonomy( $tag->taxonomy );
+            if ( is_taxonomy_viewable( $tax ) ) {
+                $wp_admin_bar->add_menu(
+                    array(
+                        'id'    => 'view',
+                        'title' => $tax->labels->view_item,
+                        'href'  => get_term_link( $tag ),
+                    )
+                );
+            }
+        } elseif ( 'user-edit' == $current_screen->base && isset( $user_id ) ) {
+            $user_object = get_userdata( $user_id );
+            $view_link   = get_author_posts_url( $user_object->ID );
+            if ( $user_object->exists() && $view_link ) {
+                $wp_admin_bar->add_menu(
+                    array(
+                        'id'    => 'view',
+                        'title' => __( 'View User' ),
+                        'href'  => $view_link,
+                    )
+                );
+            }
         }
     } else {
@@ -759 +764 @@
         }
 
-        if ( ! empty( $current_object->post_type )
-            && ( $post_type_object = get_post_type_object( $current_object->post_type ) )
-            && current_user_can( 'edit_post', $current_object->ID )
-            && $post_type_object->show_in_admin_bar
-            && $edit_post_link = get_edit_post_link( $current_object->ID ) ) {
-            $wp_admin_bar->add_menu(
-                array(
-                    'id'    => 'edit',
-                    'title' => $post_type_object->labels->edit_item,
-                    'href'  => $edit_post_link,
-                )
-            );
-        } elseif ( ! empty( $current_object->taxonomy )
-            && ( $tax = get_taxonomy( $current_object->taxonomy ) )
-            && current_user_can( 'edit_term', $current_object->term_id )
-            && $edit_term_link = get_edit_term_link( $current_object->term_id, $current_object->taxonomy ) ) {
-            $wp_admin_bar->add_menu(
-                array(
-                    'id'    => 'edit',
-                    'title' => $tax->labels->edit_item,
-                    'href'  => $edit_term_link,
-                )
-            );
-        } elseif ( is_a( $current_object, 'WP_User' )
-            && current_user_can( 'edit_user', $current_object->ID )
-            && $edit_user_link = get_edit_user_link( $current_object->ID ) ) {
-            $wp_admin_bar->add_menu(
-                array(
-                    'id'    => 'edit',
-                    'title' => __( 'Edit User' ),
-                    'href'  => $edit_user_link,
-                )
-            );
+        if ( ! empty( $current_object->post_type ) ) {
+            $post_type_object = get_post_type_object( $current_object->post_type );
+            $edit_post_link   = get_edit_post_link( $current_object->ID );
+            if ( $post_type_object
+                && $edit_post_link
+                && current_user_can( 'edit_post', $current_object->ID )
+                && $post_type_object->show_in_admin_bar ) {
+                $wp_admin_bar->add_menu(
+                    array(
+                        'id'    => 'edit',
+                        'title' => $post_type_object->labels->edit_item,
+                        'href'  => $edit_post_link,
+                    )
+                );
+            }
+        } elseif ( ! empty( $current_object->taxonomy ) ) {
+            $tax            = get_taxonomy( $current_object->taxonomy );
+            $edit_term_link = get_edit_term_link( $current_object->term_id, $current_object->taxonomy );
+            if ( $tax && $edit_term_link && current_user_can( 'edit_term', $current_object->term_id ) ) {
+                $wp_admin_bar->add_menu(
+                    array(
+                        'id'    => 'edit',
+                        'title' => $tax->labels->edit_item,
+                        'href'  => $edit_term_link,
+                    )
+                );
+            }
+        } elseif ( is_a( $current_object, 'WP_User' ) && current_user_can( 'edit_user', $current_object->ID ) ) {
+            $edit_user_link = get_edit_user_link( $current_object->ID );
+            if ( $edit_user_link ) {
+                $wp_admin_bar->add_menu(
+                    array(
+                        'id'    => 'edit',
+                        'title' => __( 'Edit User' ),
+                        'href'  => $edit_user_link,
+                    )
+                );
+            }
         }
     }