Changeset 45590 for trunk/src/wp-includes/comment.php

Timestamp:

07/02/2019 11:41:16 PM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.

See #47632.

File:

• trunk/src/wp-includes/comment.php (modified) (9 diffs)

trunk/src/wp-includes/comment.php

@@ -49 +49 @@
 
         // Check for the number of external links if a max allowed number is set.
-        if ( $max_links = get_option( 'comment_max_links' ) ) {
+        $max_links = get_option( 'comment_max_links' );
+        if ( $max_links ) {
                 $num_links = preg_match_all( '/<a [^>]*href/i', $comment, $out );
 
@@ -1039 +1040 @@
         $page = null;
 
-        if ( ! $comment = get_comment( $comment_ID ) ) {
+        $comment = get_comment( $comment_ID );
+        if ( ! $comment ) {
                 return;
         }
@@ -1360 +1362 @@
 function wp_delete_comment( $comment_id, $force_delete = false ) {
         global $wpdb;
-        if ( ! $comment = get_comment( $comment_id ) ) {
+        $comment = get_comment( $comment_id );
+        if ( ! $comment ) {
                 return false;
         }
@@ -1436 +1439 @@
         }
 
-        if ( ! $comment = get_comment( $comment_id ) ) {
+        $comment = get_comment( $comment_id );
+        if ( ! $comment ) {
                 return false;
         }
@@ -2049 +2053 @@
 
         if ( isset( $commentdata['user_ID'] ) ) {
-                $commentdata['user_id'] = $commentdata['user_ID'] = (int) $commentdata['user_ID'];
+                $commentdata['user_ID'] = (int) $commentdata['user_ID'];
+                $commentdata['user_id'] = $commentdata['user_ID'];
         }
 
@@ -2065 +2070 @@
         $commentdata['comment_post_ID'] = (int) $commentdata['comment_post_ID'];
         if ( isset( $commentdata['user_ID'] ) && $prefiltered_user_id !== (int) $commentdata['user_ID'] ) {
-                $commentdata['user_id'] = $commentdata['user_ID'] = (int) $commentdata['user_ID'];
+                $commentdata['user_ID'] = (int) $commentdata['user_ID'];
+                $commentdata['user_id'] = $commentdata['user_ID'];
         } elseif ( isset( $commentdata['user_id'] ) ) {
                 $commentdata['user_id'] = (int) $commentdata['user_id'];
@@ -2476 +2482 @@
         wp_cache_delete( "comments-{$post_id}", 'counts' );
 
-        if ( ! $post = get_post( $post_id ) ) {
+        $post = get_post( $post_id );
+        if ( ! $post ) {
                 return false;
         }
@@ -2775 +2782 @@
                 if ( ! in_array( $link_test, $pung ) && ( url_to_postid( $link_test ) != $post->ID ) // If we haven't pung it already and it isn't a link to itself
                                 && ! is_local_attachment( $link_test ) ) : // Also, let's never ping local attachments.
-                        if ( $test = @parse_url( $link_test ) ) {
+                        $test = @parse_url( $link_test );
+                        if ( $test ) {
                                 if ( isset( $test['query'] ) ) {
                                         $post_links[] = $link_test;
@@ -3135 +3143 @@
 function wp_handle_comment_submission( $comment_data ) {
 
-        $comment_post_ID = $comment_parent = $user_ID = 0;
-        $comment_author  = $comment_author_email = $comment_author_url = $comment_content = null;
+        $comment_post_ID      = 0;
+        $comment_parent       = 0;
+        $user_ID              = 0;
+        $comment_author       = null;
+        $comment_author_email = null;
+        $comment_author_url   = null;
+        $comment_content      = null;
 
         if ( isset( $comment_data['comment_post_ID'] ) ) {