Changeset 45590 for trunk/src/wp-includes/functions.php

Timestamp:

07/02/2019 11:41:16 PM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.

See #47632.

File:

• trunk/src/wp-includes/functions.php (modified) (18 diffs)

trunk/src/wp-includes/functions.php

@@ -745 +745 @@
         if ( $url != '' && ! $wpdb->get_var( $wpdb->prepare( "SELECT post_id FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = 'enclosure' AND meta_value LIKE %s", $post_ID, $wpdb->esc_like( $url ) . '%' ) ) ) {
 
-            if ( $headers = wp_get_http_headers( $url ) ) {
+            $headers = wp_get_http_headers( $url );
+            if ( $headers ) {
                 $len           = isset( $headers['content-length'] ) ? (int) $headers['content-length'] : 0;
                 $type          = isset( $headers['content-type'] ) ? $headers['content-type'] : '';
@@ -944 +945 @@
     }
 
-    if ( $frag = strstr( $uri, '#' ) ) {
+    $frag = strstr( $uri, '#' );
+    if ( $frag ) {
         $uri = substr( $uri, 0, -strlen( $frag ) );
     } else {
@@ -1699 +1701 @@
  */
 function wp_original_referer_field( $echo = true, $jump_back_to = 'current' ) {
-    if ( ! $ref = wp_get_original_referer() ) {
+    $ref = wp_get_original_referer();
+    if ( ! $ref ) {
         $ref = 'previous' == $jump_back_to ? wp_get_referer() : wp_unslash( $_SERVER['REQUEST_URI'] );
     }
@@ -1811 +1814 @@
 
     // Get the permission bits.
-    if ( $stat = @stat( $target_parent ) ) {
+    $stat = @stat( $target_parent );
+    if ( $stat ) {
         $dir_perms = $stat['mode'] & 0007777;
     } else {
@@ -2160 +2164 @@
     }
 
-    if ( ! $url = get_option( 'upload_url_path' ) ) {
+    $url = get_option( 'upload_url_path' );
+    if ( ! $url ) {
         if ( empty( $upload_path ) || ( 'wp-content/uploads' == $upload_path ) || ( $upload_path == $dir ) ) {
             $url = WP_CONTENT_URL . '/uploads';
@@ -2600 +2605 @@
             // File is a non-specific binary type. That's ok if it's a type that generally tends to be binary.
             if ( ! in_array( substr( $type, 0, strcspn( $type, '/' ) ), array( 'application', 'video', 'audio' ) ) ) {
-                $type = $ext = false;
+                $type = false;
+                $ext  = false;
             }
         } elseif ( 0 === strpos( $real_mime, 'video/' ) || 0 === strpos( $real_mime, 'audio/' ) ) {
@@ -2609 +2615 @@
              */
             if ( substr( $real_mime, 0, strcspn( $real_mime, '/' ) ) !== substr( $type, 0, strcspn( $type, '/' ) ) ) {
-                $type = $ext = false;
+                $type = false;
+                $ext  = false;
             }
         } elseif ( 'text/plain' === $real_mime ) {
@@ -2624 +2631 @@
             )
             ) {
-                $type = $ext = false;
+                $type = false;
+                $ext  = false;
             }
         } elseif ( 'text/rtf' === $real_mime ) {
@@ -2637 +2645 @@
             )
             ) {
-                $type = $ext = false;
+                $type = false;
+                $ext  = false;
             }
         } else {
@@ -2645 +2654 @@
                  * If the real content type doesn't match the file extension, assume it's dangerous.
                  */
-                $type = $ext = false;
+                $type = false;
+                $ext  = false;
             }
         }
@@ -2655 +2665 @@
 
         if ( ! in_array( $type, $allowed ) ) {
-            $type = $ext = false;
+            $type = false;
+            $ext  = false;
         }
     }
@@ -5238 +5249 @@
  */
 function wp_timezone_override_offset() {
-    if ( ! $timezone_string = get_option( 'timezone_string' ) ) {
+    $timezone_string = get_option( 'timezone_string' );
+    if ( ! $timezone_string ) {
         return false;
     }
@@ -5603 +5615 @@
      * @param array $extra_context_headers Empty array by default.
      */
-    if ( $context && $extra_headers = apply_filters( "extra_{$context}_headers", array() ) ) {
+    $extra_headers = $context ? apply_filters( "extra_{$context}_headers", array() ) : array();
+    if ( $extra_headers ) {
         $extra_headers = array_combine( $extra_headers, $extra_headers ); // keys equal values
         $all_headers   = array_merge( $extra_headers, (array) $default_headers );
@@ -5727 +5740 @@
  */
 function _wp_mysql_week( $column ) {
-    switch ( $start_of_week = (int) get_option( 'start_of_week' ) ) {
+    $start_of_week = (int) get_option( 'start_of_week' );
+    switch ( $start_of_week ) {
         case 1:
             return "WEEK( $column, 1 )";
@@ -5758 +5772 @@
     $override = is_null( $start_parent ) ? array() : array( $start => $start_parent );
 
-    if ( ! $arbitrary_loop_member = wp_find_hierarchy_loop_tortoise_hare( $callback, $start, $override, $callback_args ) ) {
+    $arbitrary_loop_member = wp_find_hierarchy_loop_tortoise_hare( $callback, $start, $override, $callback_args );
+    if ( ! $arbitrary_loop_member ) {
         return array();
     }
@@ -5786 +5801 @@
  */
 function wp_find_hierarchy_loop_tortoise_hare( $callback, $start, $override = array(), $callback_args = array(), $_return_loop = false ) {
-    $tortoise = $hare = $evanescent_hare = $start;
-    $return   = array();
+    $tortoise        = $start;
+    $hare            = $start;
+    $evanescent_hare = $start;
+    $return          = array();
 
     // Set evanescent_hare to one past hare
@@ -5799 +5816 @@
     ) {
         if ( $_return_loop ) {
-            $return[ $tortoise ] = $return[ $evanescent_hare ] = $return[ $hare ] = true;
+            $return[ $tortoise ]        = true;
+            $return[ $evanescent_hare ] = true;
+            $return[ $hare ]            = true;
         }
 
@@ -7134 +7153 @@
     }
 
-    if ( $handle = opendir( $directory ) ) {
+    $handle = opendir( $directory );
+    if ( $handle ) {
         while ( ( $file = readdir( $handle ) ) !== false ) {
             $path = $directory . '/' . $file;