Changeset 45590 for trunk/src/wp-includes/post-template.php

Timestamp:

07/02/2019 11:41:16 PM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.

See #47632.

File:

• trunk/src/wp-includes/post-template.php (modified) (8 diffs)

trunk/src/wp-includes/post-template.php

@@ -1096 +1096 @@
  */
 function the_meta() {
-    if ( $keys = get_post_custom_keys() ) {
+    $keys = get_post_custom_keys();
+    if ( $keys ) {
         $li_html = '';
         foreach ( (array) $keys as $key ) {
@@ -1604 +1605 @@
     $_post = get_post( $id );
 
-    if ( empty( $_post ) || ( 'attachment' !== $_post->post_type ) || ! $url = wp_get_attachment_url( $_post->ID ) ) {
+    if ( empty( $_post ) || ( 'attachment' !== $_post->post_type ) || ! wp_get_attachment_url( $_post->ID ) ) {
         return __( 'Missing Attachment' );
     }
+
+    $url = wp_get_attachment_url( $_post->ID );
 
     if ( $permalink ) {
@@ -1808 +1811 @@
  */
 function wp_post_revision_title( $revision, $link = true ) {
-    if ( ! $revision = get_post( $revision ) ) {
+    $revision = get_post( $revision );
+    if ( ! $revision ) {
         return $revision;
     }
@@ -1823 +1827 @@
     $currentf = __( '%s [Current Revision]' );
 
-    $date = date_i18n( $datef, strtotime( $revision->post_modified ) );
-    if ( $link && current_user_can( 'edit_post', $revision->ID ) && $link = get_edit_post_link( $revision->ID ) ) {
-        $date = "<a href='$link'>$date</a>";
+    $date      = date_i18n( $datef, strtotime( $revision->post_modified ) );
+    $edit_link = get_edit_post_link( $revision->ID );
+    if ( $link && current_user_can( 'edit_post', $revision->ID ) && $edit_link ) {
+        $date = "<a href='$edit_link'>$date</a>";
     }
 
@@ -1847 +1852 @@
  */
 function wp_post_revision_title_expanded( $revision, $link = true ) {
-    if ( ! $revision = get_post( $revision ) ) {
+    $revision = get_post( $revision );
+    if ( ! $revision ) {
         return $revision;
     }
@@ -1861 +1867 @@
     $gravatar = get_avatar( $revision->post_author, 24 );
 
-    $date = date_i18n( $datef, strtotime( $revision->post_modified ) );
-    if ( $link && current_user_can( 'edit_post', $revision->ID ) && $link = get_edit_post_link( $revision->ID ) ) {
-        $date = "<a href='$link'>$date</a>";
+    $date      = date_i18n( $datef, strtotime( $revision->post_modified ) );
+    $edit_link = get_edit_post_link( $revision->ID );
+    if ( $link && current_user_can( 'edit_post', $revision->ID ) && $edit_link ) {
+        $date = "<a href='$edit_link'>$date</a>";
     }
 
@@ -1911 +1918 @@
  */
 function wp_list_post_revisions( $post_id = 0, $type = 'all' ) {
-    if ( ! $post = get_post( $post_id ) ) {
+    $post = get_post( $post_id );
+    if ( ! $post ) {
         return;
     }
@@ -1921 +1929 @@
     }
 
-    if ( ! $revisions = wp_get_post_revisions( $post->ID ) ) {
+    $revisions = wp_get_post_revisions( $post->ID );
+    if ( ! $revisions ) {
         return;
     }