Changeset 45590 for trunk/src/wp-includes/revision.php

Timestamp:

07/02/2019 11:41:16 PM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.

See #47632.

File:

• trunk/src/wp-includes/revision.php (modified) (11 diffs)

trunk/src/wp-includes/revision.php

@@ -114 +114 @@
     }
 
-    if ( ! $post = get_post( $post_id ) ) {
+    $post = get_post( $post_id );
+    if ( ! $post ) {
         return;
     }
@@ -133 +134 @@
     // they are different, unless a plugin tells us to always save regardless.
     // If no previous revisions, save one
-    if ( $revisions = wp_get_post_revisions( $post_id ) ) {
+    $revisions = wp_get_post_revisions( $post_id );
+    if ( $revisions ) {
         // grab the last revision, but not an autosave
         foreach ( $revisions as $revision ) {
@@ -255 +257 @@
  */
 function wp_is_post_revision( $post ) {
-    if ( ! $post = wp_get_post_revision( $post ) ) {
+    $post = wp_get_post_revision( $post );
+    if ( ! $post ) {
         return false;
     }
@@ -271 +274 @@
  */
 function wp_is_post_autosave( $post ) {
-    if ( ! $post = wp_get_post_revision( $post ) ) {
+    $post = wp_get_post_revision( $post );
+    if ( ! $post ) {
         return false;
     }
@@ -341 +345 @@
  */
 function wp_get_post_revision( &$post, $output = OBJECT, $filter = 'raw' ) {
-    if ( ! $revision = get_post( $post, OBJECT, $filter ) ) {
+    $revision = get_post( $post, OBJECT, $filter );
+    if ( ! $revision ) {
         return $revision;
     }
@@ -373 +378 @@
  */
 function wp_restore_post_revision( $revision_id, $fields = null ) {
-    if ( ! $revision = wp_get_post_revision( $revision_id, ARRAY_A ) ) {
+    $revision = wp_get_post_revision( $revision_id, ARRAY_A );
+    if ( ! $revision ) {
         return $revision;
     }
@@ -426 +432 @@
  */
 function wp_delete_post_revision( $revision_id ) {
-    if ( ! $revision = wp_get_post_revision( $revision_id ) ) {
+    $revision = wp_get_post_revision( $revision_id );
+    if ( ! $revision ) {
         return $revision;
     }
@@ -483 +490 @@
     );
 
-    if ( ! $revisions = get_children( $args ) ) {
+    $revisions = get_children( $args );
+    if ( ! $revisions ) {
         return array();
     }
@@ -602 +610 @@
  */
 function _wp_preview_terms_filter( $terms, $post_id, $taxonomy ) {
-    if ( ! $post = get_post() ) {
+    $post = get_post();
+    if ( ! $post ) {
         return $terms;
     }
@@ -612 +621 @@
     if ( 'standard' == $_REQUEST['post_format'] ) {
         $terms = array();
-    } elseif ( $term = get_term_by( 'slug', 'post-format-' . sanitize_key( $_REQUEST['post_format'] ), 'post_format' ) ) {
-        $terms = array( $term ); // Can only have one post format
+    } else {
+        $term = get_term_by( 'slug', 'post-format-' . sanitize_key( $_REQUEST['post_format'] ), 'post_format' );
+        if ( $term ) {
+            $terms = array( $term ); // Can only have one post format
+        }
     }
 
@@ -631 +643 @@
  */
 function _wp_preview_post_thumbnail_filter( $value, $post_id, $meta_key ) {
-    if ( ! $post = get_post() ) {
+    $post = get_post();
+    if ( ! $post ) {
         return $value;
     }