Changeset 45590 for trunk/src/wp-includes/taxonomy.php

Timestamp:

07/02/2019 11:41:16 PM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.

See #47632.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (11 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -1404 +1404 @@
         $else_where_fields[] = $taxonomy;
 
-        if ( $result = $wpdb->get_row( $wpdb->prepare( "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE $where AND tt.taxonomy = %s $orderby $limit", $where_fields ), ARRAY_A ) ) {
+        $result = $wpdb->get_row( $wpdb->prepare( "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE $where AND tt.taxonomy = %s $orderby $limit", $where_fields ), ARRAY_A );
+        if ( $result ) {
             return $result;
         }
@@ -1411 +1412 @@
     }
 
-    if ( $result = $wpdb->get_var( $wpdb->prepare( "SELECT term_id FROM $wpdb->terms as t WHERE $where $orderby $limit", $where_fields ) ) ) {
+    $result = $wpdb->get_var( $wpdb->prepare( "SELECT term_id FROM $wpdb->terms as t WHERE $where $orderby $limit", $where_fields ) );
+    if ( $result ) {
         return $result;
     }
@@ -1751 +1753 @@
     $term = (int) $term;
 
-    if ( ! $ids = term_exists( $term, $taxonomy ) ) {
+    $ids = term_exists( $term, $taxonomy );
+    if ( ! $ids ) {
         return false;
     }
@@ -2449 +2452 @@
         }
 
-        if ( ! $term_info = term_exists( $term, $taxonomy ) ) {
+        $term_info = term_exists( $term, $taxonomy );
+        if ( ! $term_info ) {
             // Skip if a non-existent term ID is passed.
             if ( is_int( $term ) ) {
@@ -2608 +2612 @@
         }
 
-        if ( ! $term_info = term_exists( $term, $taxonomy ) ) {
+        $term_info = term_exists( $term, $taxonomy );
+        if ( ! $term_info ) {
             // Skip if a non-existent term ID is passed.
             if ( is_int( $term ) ) {
@@ -3544 +3549 @@
             $ancestors[ $term->term_id ] = 1;
 
-            if ( $children = _get_term_children( $term->term_id, $terms, $taxonomy, $ancestors ) ) {
+            $children = _get_term_children( $term->term_id, $terms, $taxonomy, $ancestors );
+            if ( $children ) {
                 $term_list = array_merge( $term_list, $children );
             }
@@ -3681 +3687 @@
     $object_types = array_unique( $object_types );
 
-    if ( false !== ( $check_attachments = array_search( 'attachment', $object_types ) ) ) {
+    $check_attachments = array_search( 'attachment', $object_types );
+    if ( false !== $check_attachments ) {
         unset( $object_types[ $check_attachments ] );
         $check_attachments = true;
@@ -3949 +3956 @@
     // Split term data recording is slow, so we do it just once, outside the loop.
     $split_term_data    = get_option( '_split_terms', array() );
-    $skipped_first_term = $taxonomies = array();
+    $skipped_first_term = array();
+    $taxonomies         = array();
     foreach ( $shared_tts as $shared_tt ) {
         $term_id = intval( $shared_tt->term_id );
@@ -4386 +4394 @@
  */
 function is_object_in_term( $object_id, $taxonomy, $terms = null ) {
-    if ( ! $object_id = (int) $object_id ) {
+    $object_id = (int) $object_id;
+    if ( ! $object_id ) {
         return new WP_Error( 'invalid_object', __( 'Invalid object ID.' ) );
     }
@@ -4412 +4421 @@
     $terms = (array) $terms;
 
-    if ( $ints = array_filter( $terms, 'is_int' ) ) {
+    $ints = array_filter( $terms, 'is_int' );
+    if ( $ints ) {
         $strs = array_diff( $terms, $ints );
     } else {
@@ -4559 +4569 @@
 
     // Now look for larger loops.
-    if ( ! $loop = wp_find_hierarchy_loop( 'wp_get_term_taxonomy_parent_id', $term_id, $parent, array( $taxonomy ) ) ) {
+    $loop = wp_find_hierarchy_loop( 'wp_get_term_taxonomy_parent_id', $term_id, $parent, array( $taxonomy ) );
+    if ( ! $loop ) {
         return $parent; // No loop
     }