Changeset 45596

Timestamp:

07/04/2019 09:22:17 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Twenty Nineteen: Fix markup errors in twentynineteen_add_ellipses_to_nav():

• Add missing i18n for aria-label attribute.
• Remove redundant screen reader text superseded by aria-label.
• Remove unnecessary id and class attributes.

Props afercia, chetan200891, ianbelanger.
Fixes #47067.

File:

• trunk/src/wp-content/themes/twentynineteen/inc/template-functions.php (modified) (1 diff)

trunk/src/wp-content/themes/twentynineteen/inc/template-functions.php

@@ -207 +207 @@
                 <ul class="main-menu">
                     <li class="menu-item menu-item-has-children">
-                        <button class="submenu-expand main-menu-more-toggle is-empty" tabindex="-1" aria-label="More" aria-haspopup="true" aria-expanded="false">
-                            <span class="screen-reader-text">' . esc_html__( 'More', 'twentynineteen' ) . '</span>' .
+                        <button class="submenu-expand main-menu-more-toggle is-empty" tabindex="-1"
+                            aria-label="' . esc_attr__( 'More', 'twentynineteen' ) . '" aria-haspopup="true" aria-expanded="false">' .
                             twentynineteen_get_icon_svg( 'arrow_drop_down_ellipsis' ) . '
                         </button>
                         <ul class="sub-menu hidden-links">
-                            <li id="menu-item--1" class="mobile-parent-nav-menu-item menu-item--1">
+                            <li class="mobile-parent-nav-menu-item">
                                 <button class="menu-item-link-return">' .
                                     twentynineteen_get_icon_svg( 'chevron_left' ) .