Changeset 45601

Timestamp:

07/05/2019 03:13:31 AM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix all WordPress.CodeAnalysis.AssignmentInCondition issues.

WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition can be ignored, as this is allowed in Core.

See #47632.

Location:

trunk

Files:

• phpcs.xml.dist (modified) (1 diff)
• src/wp-includes/revision.php (modified) (1 diff)

trunk/phpcs.xml.dist

@@ -185 +185 @@
         </rule>
 
+        <!-- Assignments in while conditions are a valid method of looping over iterables -->
+        <rule ref="WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition">
+                <exclude-pattern>*</exclude-pattern>
+        </rule>
+
         <!-- Exclude the unit tests from select sniffs. -->
         <rule ref="WordPress.Files.FileName.NotHyphenatedLowercase">

trunk/src/wp-includes/revision.php

@@ -157 +157 @@
                  * @param WP_Post $post              The post object.
                  */
-                if ( isset( $last_revision ) && apply_filters( 'wp_save_post_revision_check_for_changes', $check_for_changes = true, $last_revision, $post ) ) {
+                if ( isset( $last_revision ) && apply_filters( 'wp_save_post_revision_check_for_changes', true, $last_revision, $post ) ) {
                         $post_has_changed = false;