Changeset 45607 for trunk/tests/phpunit/includes/phpunit7/speed-trap-listener.php

Timestamp:

07/08/2019 12:55:20 AM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix the remaining issues in /tests.

All PHP files in /tests now conform to the PHP coding standards, or have exceptions appropriately marked.

Travis now also runs phpcs on the /tests directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉

See #47632.

File:

• trunk/tests/phpunit/includes/phpunit7/speed-trap-listener.php (modified) (9 diffs)

trunk/tests/phpunit/includes/phpunit7/speed-trap-listener.php

@@ -23 +23 @@
          * @var int
          */
-        protected $slowThreshold;
+        protected $slow_threshold;
 
         /**
@@ -30 +30 @@
          * @var int
          */
-        protected $reportLength;
+        protected $report_length;
 
         /**
@@ -167 +167 @@
          *
          * @param int $time          Test execution time in milliseconds
-         * @param int $slowThreshold Test execution time at which a test should be considered slow (milliseconds)
+         * @param int $slow_threshold Test execution time at which a test should be considered slow (milliseconds)
          * @return bool
          */
-        protected function isSlow( $time, $slowThreshold ) {
-                return $time >= $slowThreshold;
+        protected function isSlow( $time, $slow_threshold ) {
+                return $time >= $slow_threshold;
         }
 
@@ -221 +221 @@
          */
         protected function getReportLength() {
-                return min( count( $this->slow ), $this->reportLength );
+                return min( count( $this->slow ), $this->report_length );
         }
 
@@ -245 +245 @@
          */
         protected function renderHeader() {
-                echo sprintf( "\n\nYou should really fix these slow tests (>%sms)...\n", $this->slowThreshold );
+                echo sprintf( "\n\nYou should really fix these slow tests (>%sms)...\n", $this->slow_threshold );
         }
 
@@ -252 +252 @@
          */
         protected function renderBody() {
-                $slowTests = $this->slow;
-
-                $length = $this->getReportLength( $slowTests );
+                $slow_tests = $this->slow;
+
+                $length = $this->getReportLength( $slow_tests );
                 for ( $i = 1; $i <= $length; ++$i ) {
-                        $label = key( $slowTests );
-                        $time  = array_shift( $slowTests );
+                        $label = key( $slow_tests );
+                        $time  = array_shift( $slow_tests );
 
                         echo sprintf( " %s. %sms to run %s\n", $i, $time, $label );
@@ -269 +269 @@
                 $hidden = $this->getHiddenCount( $this->slow );
                 if ( $hidden ) {
-                        echo sprintf( '...and there %s %s more above your threshold hidden from view', $hidden == 1 ? 'is' : 'are', $hidden );
+                        echo sprintf( '...and there %s %s more above your threshold hidden from view', 1 === $hidden ? 'is' : 'are', $hidden );
                 }
         }
@@ -279 +279 @@
          */
         protected function loadOptions( array $options ) {
-                $this->slowThreshold = isset( $options['slowThreshold'] ) ? $options['slowThreshold'] : 500;
-                $this->reportLength  = isset( $options['reportLength'] ) ? $options['reportLength'] : 10;
+                $this->slow_threshold = isset( $options['slowThreshold'] ) ? $options['slowThreshold'] : 500;
+                $this->report_length  = isset( $options['reportLength'] ) ? $options['reportLength'] : 10;
         }
 
@@ -303 +303 @@
                 $ann = $test->getAnnotations();
 
-                return isset( $ann['method']['slowThreshold'][0] ) ? $ann['method']['slowThreshold'][0] : $this->slowThreshold;
+                return isset( $ann['method']['slowThreshold'][0] ) ? $ann['method']['slowThreshold'][0] : $this->slow_threshold;
         }
 }