Changeset 45607 for trunk/tests/phpunit/tests/db.php
- Timestamp:
- 07/08/2019 12:55:20 AM (6 years ago)
- File:
-
- 1 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/tests/phpunit/tests/db.php
r45603 r45607 24 24 public static function setUpBeforeClass() { 25 25 parent::setUpBeforeClass(); 26 self::$_wpdb = new wpdb_exposed_methods_for_testing();26 self::$_wpdb = new WpdbExposedMethodsForTesting(); 27 27 } 28 28 … … 347 347 348 348 public function filter_allowed_incompatible_sql_mode( $modes ) { 349 $pos = array_search( 'ONLY_FULL_GROUP_BY', $modes );349 $pos = array_search( 'ONLY_FULL_GROUP_BY', $modes, true ); 350 350 $this->assertGreaterThanOrEqual( 0, $pos ); 351 351 … … 366 366 $id = 0; 367 367 // This, obviously, is an incorrect prepare. 368 // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared 368 369 $prepared = $wpdb->prepare( "SELECT * FROM $wpdb->users WHERE id = $id", $id ); 369 370 $this->assertEquals( "SELECT * FROM $wpdb->users WHERE id = 0", $prepared ); … … 383 384 global $wpdb; 384 385 386 // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged 385 387 $prepared = @$wpdb->prepare( "SELECT * FROM $wpdb->users WHERE id = %d AND user_login = %s", 1, array( 'admin' ) ); 386 388 $this->assertEquals( "SELECT * FROM $wpdb->users WHERE id = 1 AND user_login = ''", $prepared ); 387 389 390 // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged 388 391 $prepared = @$wpdb->prepare( "SELECT * FROM $wpdb->users WHERE id = %d AND user_login = %s", array( 1 ), 'admin' ); 389 392 $this->assertEquals( "SELECT * FROM $wpdb->users WHERE id = 0 AND user_login = 'admin'", $prepared ); … … 403 406 global $wpdb; 404 407 408 // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged 405 409 $prepared = @$wpdb->prepare( "SELECT * FROM $wpdb->users WHERE id = %d AND user_login = %s", array( 1, array( 'admin' ) ) ); 406 410 $this->assertEquals( "SELECT * FROM $wpdb->users WHERE id = 1 AND user_login = ''", $prepared ); 407 411 412 // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged 408 413 $prepared = @$wpdb->prepare( "SELECT * FROM $wpdb->users WHERE id = %d AND user_login = %s", array( array( 1 ), 'admin' ) ); 409 414 $this->assertEquals( "SELECT * FROM $wpdb->users WHERE id = 0 AND user_login = 'admin'", $prepared ); … … 421 426 array_unshift( $args, $query ); 422 427 428 // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged 423 429 $prepared = @call_user_func_array( array( $wpdb, 'prepare' ), $args ); 424 430 $this->assertEquals( $expected, $prepared ); … … 588 594 $wpdb->last_result = $last_result; 589 595 596 // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared 590 597 $result = $wpdb->get_col( $query, $column ); 591 598 … … 1044 1051 } 1045 1052 1046 if ( ! in_array( $expected_charset, array( 'utf8', 'utf8mb4', 'latin1' ) ) ) {1053 if ( ! in_array( $expected_charset, array( 'utf8', 'utf8mb4', 'latin1' ), true ) ) { 1047 1054 $this->markTestSkipped( 'This test only works with utf8, utf8mb4 or latin1 character sets' ); 1048 1055 } … … 1117 1124 ); 1118 1125 1119 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1126 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1120 1127 1121 1128 $this->assertNull( $row->meta_value ); … … 1140 1147 ); 1141 1148 1142 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1149 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1143 1150 1144 1151 $this->assertSame( $value, $row->meta_value ); … … 1155 1162 ); 1156 1163 1157 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1164 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1158 1165 1159 1166 $this->assertNull( $row->meta_value ); … … 1178 1185 ); 1179 1186 1180 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1187 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1181 1188 1182 1189 $this->assertNull( $row->meta_value ); … … 1193 1200 ); 1194 1201 1195 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1202 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1196 1203 1197 1204 $this->assertSame( $value, $row->meta_value ); … … 1216 1223 ); 1217 1224 1218 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1225 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1219 1226 1220 1227 $this->assertNull( $row->meta_value ); … … 1229 1236 ); 1230 1237 1231 $row = $wpdb->get_row( "SELECT * FROM $wpdb->postmeta WHERE meta_key='$key'");1238 $row = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE meta_key=%s", $key ) ); 1232 1239 1233 1240 $this->assertNull( $row ); … … 1573 1580 $sql = str_replace( '{ESCAPE}', $escape, $sql ); 1574 1581 1582 // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared 1575 1583 $actual = $wpdb->prepare( $sql, $values ); 1576 1584 … … 1654 1662 $wpdb->query( "CREATE TABLE {$wpdb->prefix}test_placeholder( a VARCHAR(100) );" ); 1655 1663 $sql = $wpdb->prepare( "INSERT INTO {$wpdb->prefix}test_placeholder VALUES(%s)", $value ); 1664 1665 // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared 1656 1666 $wpdb->query( $sql ); 1657 1667 … … 1668 1678 1669 1679 $sql = $wpdb->prepare( ' %s %1$c ', 'foo' ); 1680 // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared 1670 1681 $sql = $wpdb->prepare( " $sql %s ", 'foo' ); 1671 1682
Note: See TracChangeset
for help on using the changeset viewer.