Changeset 45607 for trunk/tests/phpunit/tests/user.php

Timestamp:

07/08/2019 12:55:20 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Fix the remaining issues in /tests.

All PHP files in /tests now conform to the PHP coding standards, or have exceptions appropriately marked.

Travis now also runs phpcs on the /tests directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉

See #47632.

File:

• trunk/tests/phpunit/tests/user.php (modified) (13 diffs)

trunk/tests/phpunit/tests/user.php

@@ -82 +82 @@
         foreach ( $user_list as $user ) {
             // only include the users we just created - there might be some others that existed previously
-            if ( in_array( $user->ID, $nusers ) ) {
+            if ( in_array( $user->ID, $nusers, true ) ) {
                 $found[] = $user->ID;
             }
@@ -162 +162 @@
         // so we'll just check to make sure our values are included somewhere.
         foreach ( $vals as $k => $v ) {
-            $this->assertTrue( isset( $out[ $k ] ) && $out[ $k ][0] == $v );
+            $this->assertTrue( isset( $out[ $k ] ) && $out[ $k ][0] === $v );
         }
         // delete one key and check again
@@ -171 +171 @@
         // make sure that key is excluded from the results
         foreach ( $vals as $k => $v ) {
-            if ( $k == $key_to_delete ) {
+            if ( $k === $key_to_delete ) {
                 $this->assertFalse( isset( $out[ $k ] ) );
             } else {
-                $this->assertTrue( isset( $out[ $k ] ) && $out[ $k ][0] == $v );
+                $this->assertTrue( isset( $out[ $k ] ) && $out[ $k ][0] === $v );
             }
         }
@@ -600 +600 @@
         }
 
-        @update_user_meta( $id2, 'key', 'value' );
+        update_user_meta( $id2, 'key', 'value' );
 
         $metas = array_keys( get_user_meta( 1 ) );
@@ -1023 +1023 @@
         );
 
-        $this->assertTrue( in_array( self::$contrib_id, $users ) );
+        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
     }
 
@@ -1034 +1034 @@
         );
 
-        $this->assertTrue( in_array( self::$contrib_id, $users ) );
+        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
     }
 
@@ -1045 +1045 @@
         );
 
-        $this->assertTrue( in_array( self::$contrib_id, $users ) );
+        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
     }
 
@@ -1056 +1056 @@
         );
 
-        $this->assertTrue( in_array( self::$contrib_id, $users ) );
+        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
     }
 
@@ -1067 +1067 @@
         );
 
-        $this->assertTrue( in_array( self::$contrib_id, $users ) );
+        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
     }
 
@@ -1202 +1202 @@
          */
         if ( ! empty( $GLOBALS['phpmailer']->mock_sent ) ) {
-            $was_admin_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && WP_TESTS_EMAIL == $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
-            $was_user_email_sent  = ( isset( $GLOBALS['phpmailer']->mock_sent[1] ) && 'blackburn@battlefield3.com' == $GLOBALS['phpmailer']->mock_sent[1]['to'][0][0] );
+            $was_admin_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && WP_TESTS_EMAIL === $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
+            $was_user_email_sent  = ( isset( $GLOBALS['phpmailer']->mock_sent[1] ) && 'blackburn@battlefield3.com' === $GLOBALS['phpmailer']->mock_sent[1]['to'][0][0] );
         }
 
@@ -1227 +1227 @@
          */
         if ( ! empty( $GLOBALS['phpmailer']->mock_sent ) ) {
-            $was_admin_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && WP_TESTS_EMAIL == $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
-            $was_user_email_sent  = ( isset( $GLOBALS['phpmailer']->mock_sent[1] ) && 'blackburn@battlefield3.com' == $GLOBALS['phpmailer']->mock_sent[1]['to'][0][0] );
+            $was_admin_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && WP_TESTS_EMAIL === $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
+            $was_user_email_sent  = ( isset( $GLOBALS['phpmailer']->mock_sent[1] ) && 'blackburn@battlefield3.com' === $GLOBALS['phpmailer']->mock_sent[1]['to'][0][0] );
         }
 
@@ -1466 +1466 @@
 
         if ( ! empty( $GLOBALS['phpmailer']->mock_sent ) ) {
-            $was_confirmation_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && 'after@example.com' == $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
+            $was_confirmation_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && 'after@example.com' === $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
         }
 
@@ -1503 +1503 @@
 
         if ( ! empty( $GLOBALS['phpmailer']->mock_sent ) ) {
-            $was_confirmation_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && 'after@example.com' == $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
+            $was_confirmation_email_sent = ( isset( $GLOBALS['phpmailer']->mock_sent[0] ) && 'after@example.com' === $GLOBALS['phpmailer']->mock_sent[0]['to'][0][0] );
         }