Changeset 45610

Timestamp:

07/09/2019 01:09:53 AM (6 years ago)

Author:

azaozz

Message:

TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018.

Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911.

Location:

trunk/src

Files:

• js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js (modified) (5 diffs)
• wp-includes/css/editor.css (modified) (1 diff)

trunk/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js

@@ -789 +789 @@
             mceToolbar,
             mceStatusbar,
-            wpStatusbar,
-            isChromeRtl = ( editor.rtl && /Chrome/.test( navigator.userAgent ) );
+            wpStatusbar;
 
             if ( container ) {
@@ -1041 +1040 @@
             toolbar.on( 'show', function() {
                 this.reposition();
-
-                if ( isChromeRtl ) {
-                    tinymce.$( '.mce-widget.mce-tooltip' ).addClass( 'wp-hide-mce-tooltip' );
-                }
-            } );
-
-            toolbar.on( 'hide', function() {
-                if ( isChromeRtl ) {
-                    tinymce.$( '.mce-widget.mce-tooltip' ).removeClass( 'wp-hide-mce-tooltip' );
-                }
             } );
 
@@ -1141 +1130 @@
         }
 
-        editor.dom.bind( editor.getWin(), 'resize', hide );
-
         if ( editor.inline ) {
+            editor.on( 'resizewindow', hide );
+
             // Enable `capture` for the event.
             // This will hide/reposition the toolbar on any scrolling in the document.
@@ -1149 +1138 @@
         } else {
             editor.dom.bind( editor.getWin(), 'scroll', hide );
+
             // For full height iframe editor.
             editor.on( 'resizewindow scrollwindow', hide );
@@ -1156 +1146 @@
             document.removeEventListener( 'scroll', hide, true );
             editor.off( 'resizewindow scrollwindow', hide );
-            editor.dom.unbind( editor.getWin(), 'resize scroll', hide );
+            editor.dom.unbind( editor.getWin(), 'scroll', hide );
         } );
 

trunk/src/wp-includes/css/editor.css

@@ -802 +802 @@
 .mce-tooltip {
     margin-top: 2px;
-}
-
-/* Don't show the tooltip. Used in Chrome RTL, see #42018 */
-.rtl .mce-tooltip.wp-hide-mce-tooltip {
-    display: none !important;
 }