Changeset 45611 for trunk/src/wp-admin/includes/class-wp-filesystem-direct.php

Timestamp:

07/09/2019 05:44:42 AM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-admin/includes/class-wp-filesystem-direct.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-wp-filesystem-direct.php

@@ -96 +96 @@
          */
         public function cwd() {
-                return @getcwd();
+                return getcwd();
         }
 
@@ -127 +127 @@
                 }
                 if ( ! $recursive ) {
-                        return @chgrp( $file, $group );
+                        return chgrp( $file, $group );
                 }
                 if ( ! $this->is_dir( $file ) ) {
-                        return @chgrp( $file, $group );
+                        return chgrp( $file, $group );
                 }
                 // Is a directory, and we want recursive
@@ -166 +166 @@
 
                 if ( ! $recursive || ! $this->is_dir( $file ) ) {
-                        return @chmod( $file, $mode );
+                        return chmod( $file, $mode );
                 }
                 // Is a directory, and we want recursive
@@ -194 +194 @@
                 }
                 if ( ! $recursive ) {
-                        return @chown( $file, $owner );
+                        return chown( $file, $owner );
                 }
                 if ( ! $this->is_dir( $file ) ) {
-                        return @chown( $file, $owner );
+                        return chown( $file, $owner );
                 }
                 // Is a directory, and we want recursive
@@ -477 +477 @@
                         $atime = time();
                 }
-                return @touch( $file, $time, $atime );
+                return touch( $file, $time, $atime );
         }
 
@@ -565 +565 @@
                 }
 
-                if ( ! $this->is_dir( $path ) ) {
-                        return false;
-                }
-
-                $dir = @dir( $path );
+                if ( ! $this->is_dir( $path ) || ! $this->is_readable( $dir ) ) {
+                        return false;
+                }
+
+                $dir = dir( $path );
                 if ( ! $dir ) {
                         return false;