Changeset 45611 for trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

Timestamp:

07/09/2019 05:44:42 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php (modified) (12 diffs)

trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -115 +115 @@
 
         // Set the Connection to use Passive FTP
-        @ftp_pasv( $this->link, true );
+        ftp_pasv( $this->link, true );
         if ( @ftp_get_option( $this->link, FTP_TIMEOUT_SEC ) < FS_TIMEOUT ) {
             @ftp_set_option( $this->link, FTP_TIMEOUT_SEC, FS_TIMEOUT );
@@ -141 +141 @@
         }
 
-        if ( ! @ftp_fget( $this->link, $temp, $file, FTP_BINARY ) ) {
+        if ( ! ftp_fget( $this->link, $temp, $file, FTP_BINARY ) ) {
             fclose( $temp );
             unlink( $tempfile );
@@ -206 +206 @@
         fseek( $temp, 0 ); // Skip back to the start of the file being written to
 
-        $ret = @ftp_fput( $this->link, $file, $temp, FTP_BINARY );
+        $ret = ftp_fput( $this->link, $file, $temp, FTP_BINARY );
 
         fclose( $temp );
@@ -224 +224 @@
      */
     public function cwd() {
-        $cwd = @ftp_pwd( $this->link );
+        $cwd = ftp_pwd( $this->link );
         if ( $cwd ) {
             $cwd = trailingslashit( $cwd );
@@ -276 +276 @@
         // chmod the file or directory
         if ( ! function_exists( 'ftp_chmod' ) ) {
-            return (bool) @ftp_site( $this->link, sprintf( 'CHMOD %o %s', $mode, $file ) );
-        }
-        return (bool) @ftp_chmod( $this->link, $mode, $file );
+            return (bool) ftp_site( $this->link, sprintf( 'CHMOD %o %s', $mode, $file ) );
+        }
+        return (bool) ftp_chmod( $this->link, $mode, $file );
     }
 
@@ -376 +376 @@
         }
         if ( 'f' == $type || $this->is_file( $file ) ) {
-            return @ftp_delete( $this->link, $file );
+            return ftp_delete( $this->link, $file );
         }
         if ( ! $recursive ) {
-            return @ftp_rmdir( $this->link, $file );
+            return ftp_rmdir( $this->link, $file );
         }
 
@@ -388 +388 @@
             }
         }
-        return @ftp_rmdir( $this->link, $file );
+        return ftp_rmdir( $this->link, $file );
     }
 
@@ -400 +400 @@
      */
     public function exists( $file ) {
-        $list = @ftp_nlist( $this->link, $file );
+        $list = ftp_nlist( $this->link, $file );
 
         if ( empty( $list ) && $this->is_dir( $file ) ) {
@@ -537 +537 @@
         }
 
-        if ( ! @ftp_mkdir( $this->link, $path ) ) {
+        if ( ! ftp_mkdir( $this->link, $path ) ) {
             return false;
         }
@@ -588 +588 @@
             $b['hour']   = $lucifer[4];
             $b['minute'] = $lucifer[5];
-            $b['time']   = @mktime( $lucifer[4] + ( strcasecmp( $lucifer[6], 'PM' ) == 0 ? 12 : 0 ), $lucifer[5], 0, $lucifer[1], $lucifer[2], $lucifer[3] );
+            $b['time']   = mktime( $lucifer[4] + ( strcasecmp( $lucifer[6], 'PM' ) == 0 ? 12 : 0 ), $lucifer[5], 0, $lucifer[1], $lucifer[2], $lucifer[3] );
             $b['am/pm']  = $lucifer[6];
             $b['name']   = $lucifer[8];
@@ -618 +618 @@
                     sscanf( $lucifer[5], '%d-%d-%d', $b['year'], $b['month'], $b['day'] );
                     sscanf( $lucifer[6], '%d:%d', $b['hour'], $b['minute'] );
-                    $b['time'] = @mktime( $b['hour'], $b['minute'], 0, $b['month'], $b['day'], $b['year'] );
+                    $b['time'] = mktime( $b['hour'], $b['minute'], 0, $b['month'], $b['day'], $b['year'] );
                     $b['name'] = $lucifer[7];
                 } else {
@@ -679 +679 @@
         }
 
-        $pwd = @ftp_pwd( $this->link );
+        $pwd = ftp_pwd( $this->link );
         if ( ! @ftp_chdir( $this->link, $path ) ) { // Can't change to folder = folder doesn't exist.
             return false;
         }
-        $list = @ftp_rawlist( $this->link, '-a', false );
+        $list = ftp_rawlist( $this->link, '-a', false );
         @ftp_chdir( $this->link, $pwd );