WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (8 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-filesystem-ssh2.php

    r45583 r45611  
    485485     */
    486486    public function move( $source, $destination, $overwrite = false ) {
    487         return @ssh2_sftp_rename( $this->sftp_link, $source, $destination );
     487        if ( $this->exists( $destination ) ) {
     488            if ( $overwrite ) {
     489                // We need to remove the destination file before we can rename the source.
     490                $this->delete( $destination, false, 'f' );
     491            } else {
     492                // If we're not overwriting, the rename will fail, so return early.
     493                return false;
     494            }
     495        }
     496
     497        return ssh2_sftp_rename( $this->sftp_link, $source, $destination );
    488498    }
    489499
     
    712722        }
    713723
    714         if ( ! $this->is_dir( $path ) ) {
     724        if ( ! $this->is_dir( $path ) || ! $this->is_readable( $path ) ) {
    715725            return false;
    716726        }
    717727
    718728        $ret = array();
    719         $dir = @dir( $this->sftp_path( $path ) );
     729        $dir = dir( $this->sftp_path( $path ) );
    720730
    721731        if ( ! $dir ) {
Note: See TracChangeset for help on using the changeset viewer.