Changeset 45611 for trunk/src/wp-admin/includes/file.php

Timestamp:

07/09/2019 05:44:42 AM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-admin/includes/file.php (modified) (6 diffs)

trunk/src/wp-admin/includes/file.php

@@ -166 +166 @@
                         }
                 }
-        }
-        @closedir( $dir );
+
+                closedir( $dir );
+        }
 
         return $files;
@@ -515 +516 @@
 
                 // Make sure PHP process doesn't die before loopback requests complete.
-                @set_time_limit( 300 );
+                set_time_limit( 300 );
 
                 // Time to wait for loopback requests to finish.
@@ -781 +782 @@
 
         // A properly uploaded file will pass this test. There should be no reason to override this one.
-        $test_uploaded_file = 'wp_handle_upload' === $action ? @ is_uploaded_file( $file['tmp_name'] ) : @ is_readable( $file['tmp_name'] );
+        $test_uploaded_file = 'wp_handle_upload' === $action ? is_uploaded_file( $file['tmp_name'] ) : @is_readable( $file['tmp_name'] );
         if ( ! $test_uploaded_file ) {
                 return call_user_func_array( $upload_error_handler, array( &$file, __( 'Specified file failed upload test.' ) ) );
@@ -849 +850 @@
         if ( null === $move_new_file ) {
                 if ( 'wp_handle_upload' === $action ) {
-                        $move_new_file = @ move_uploaded_file( $file['tmp_name'], $new_file );
+                        $move_new_file = @move_uploaded_file( $file['tmp_name'], $new_file );
                 } else {
                         // use copy and unlink because rename breaks streams.
-                        $move_new_file = @ copy( $file['tmp_name'], $new_file );
+                        // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
+                        $move_new_file = @copy( $file['tmp_name'], $new_file );
                         unlink( $file['tmp_name'] );
                 }
@@ -869 +871 @@
         $stat  = stat( dirname( $new_file ) );
         $perms = $stat['mode'] & 0000666;
-        @ chmod( $new_file, $perms );
+        chmod( $new_file, $perms );
 
         // Compute the URL.
@@ -1855 +1857 @@
                         }
 
-                        @fclose( $temp_handle );
+                        fclose( $temp_handle );
                         @unlink( $temp_file_name );
                 }