Changeset 45611 for trunk/src/wp-admin/includes/image.php

Timestamp:

07/09/2019 05:44:42 AM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-admin/includes/image.php (modified) (4 diffs)

trunk/src/wp-admin/includes/image.php

@@ -164 +164 @@
     if ( empty( $image_meta ) || ! isset( $image_meta['width'], $image_meta['height'] ) ) {
         // New uploaded image.
-        $imagesize            = getimagesize( $file );
+        $imagesize            = @getimagesize( $file );
         $image_meta['width']  = $imagesize[0];
         $image_meta['height'] = $imagesize[1];
@@ -451 +451 @@
  */
 function wp_exif_frac2dec( $str ) {
-    @list( $n, $d ) = explode( '/', $str );
+    if ( false === strpos( $str, '/' ) ) {
+        return $str;
+    }
+
+    list( $n, $d ) = explode( '/', $str );
     if ( ! empty( $d ) ) {
         return $n / $d;
@@ -467 +471 @@
  */
 function wp_exif_date2ts( $str ) {
-    @list( $date, $time ) = explode( ' ', trim( $str ) );
-    @list( $y, $m, $d )   = explode( ':', $date );
+    list( $date, $time ) = explode( ' ', trim( $str ) );
+    list( $y, $m, $d )   = explode( ':', $date );
 
     return strtotime( "{$y}-{$m}-{$d} {$time}" );
@@ -864 +868 @@
         wp_mkdir_p( dirname( $dst_file ) );
 
-        if ( ! @copy( $src_file, $dst_file ) ) {
+        if ( ! copy( $src_file, $dst_file ) ) {
             $dst_file = false;
         }