Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (7 years ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/image.php

    r45543 r45611  
    164164        if ( empty( $image_meta ) || ! isset( $image_meta['width'], $image_meta['height'] ) ) {
    165165                // New uploaded image.
    166                 $imagesize            = getimagesize( $file );
     166                $imagesize            = @getimagesize( $file );
    167167                $image_meta['width']  = $imagesize[0];
    168168                $image_meta['height'] = $imagesize[1];
    … …  
    451451 */
    452452function wp_exif_frac2dec( $str ) {
    453         @list( $n, $d ) = explode( '/', $str );
     453        if ( false === strpos( $str, '/' ) ) {
     454                return $str;
     455        }
     456
     457        list( $n, $d ) = explode( '/', $str );
    454458        if ( ! empty( $d ) ) {
    455459                return $n / $d;
    … …  
    467471 */
    468472function wp_exif_date2ts( $str ) {
    469         @list( $date, $time ) = explode( ' ', trim( $str ) );
    470         @list( $y, $m, $d )   = explode( ':', $date );
     473        list( $date, $time ) = explode( ' ', trim( $str ) );
     474        list( $y, $m, $d )   = explode( ':', $date );
    471475
    472476        return strtotime( "{$y}-{$m}-{$d} {$time}" );
    … …  
    864868                wp_mkdir_p( dirname( $dst_file ) );
    865869
    866                 if ( ! @copy( $src_file, $dst_file ) ) {
     870                if ( ! copy( $src_file, $dst_file ) ) {
    867871                        $dst_file = false;
    868872                }
Note: See TracChangeset for help on using the changeset viewer.