WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (9 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-image-editor-imagick.php

    r45538 r45611  
    114114
    115115        try {
     116            // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
    116117            return ( (bool) @Imagick::queryFormats( $imagick_extension ) );
    117118        } catch ( Exception $e ) {
     
    655656        $stat  = stat( dirname( $filename ) );
    656657        $perms = $stat['mode'] & 0000666; //same permissions as parent folder, strip off the executable bits
    657         @ chmod( $filename, $perms );
     658        chmod( $filename, $perms );
    658659
    659660        /** This filter is documented in wp-includes/class-wp-image-editor-gd.php */
Note: See TracChangeset for help on using the changeset viewer.