Changeset 45611 for trunk/src/wp-includes/class-wp-image-editor-imagick.php

Timestamp:

07/09/2019 05:44:42 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-includes/class-wp-image-editor-imagick.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-image-editor-imagick.php

@@ -114 +114 @@
 
         try {
+            // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
             return ( (bool) @Imagick::queryFormats( $imagick_extension ) );
         } catch ( Exception $e ) {
@@ -655 +656 @@
         $stat  = stat( dirname( $filename ) );
         $perms = $stat['mode'] & 0000666; //same permissions as parent folder, strip off the executable bits
-        @ chmod( $filename, $perms );
+        chmod( $filename, $perms );
 
         /** This filter is documented in wp-includes/class-wp-image-editor-gd.php */