WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/09/2019 05:44:42 AM (8 months ago)
Author:
pento
Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

  • The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
  • Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
  • Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
  • Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/comment.php

    r45590 r45611  
    26092609        $quote                   = ( $pingback_link_offset_dquote ) ? '"' : '\'';
    26102610        $pingback_link_offset    = ( $quote == '"' ) ? $pingback_link_offset_dquote : $pingback_link_offset_squote;
    2611         $pingback_href_pos       = @strpos( $contents, 'href=', $pingback_link_offset );
     2611        $pingback_href_pos       = strpos( $contents, 'href=', $pingback_link_offset );
    26122612        $pingback_href_start     = $pingback_href_pos + 6;
    2613         $pingback_href_end       = @strpos( $contents, $quote, $pingback_href_start );
     2613        $pingback_href_end       = strpos( $contents, $quote, $pingback_href_start );
    26142614        $pingback_server_url_len = $pingback_href_end - $pingback_href_start;
    26152615        $pingback_server_url     = substr( $contents, $pingback_href_start, $pingback_server_url_len );
     
    28092809
    28102810        if ( $pingback_server_url ) {
    2811             @ set_time_limit( 60 );
     2811            set_time_limit( 60 );
    28122812            // Now, the RPC call
    28132813            $pagelinkedfrom = get_permalink( $post );
Note: See TracChangeset for help on using the changeset viewer.