Changeset 45611 for trunk/src/wp-includes/comment.php

Timestamp:

07/09/2019 05:44:42 AM (5 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-includes/comment.php (modified) (2 diffs)

trunk/src/wp-includes/comment.php

@@ -2609 +2609 @@
         $quote                   = ( $pingback_link_offset_dquote ) ? '"' : '\'';
         $pingback_link_offset    = ( $quote == '"' ) ? $pingback_link_offset_dquote : $pingback_link_offset_squote;
-        $pingback_href_pos       = @strpos( $contents, 'href=', $pingback_link_offset );
+        $pingback_href_pos       = strpos( $contents, 'href=', $pingback_link_offset );
         $pingback_href_start     = $pingback_href_pos + 6;
-        $pingback_href_end       = @strpos( $contents, $quote, $pingback_href_start );
+        $pingback_href_end       = strpos( $contents, $quote, $pingback_href_start );
         $pingback_server_url_len = $pingback_href_end - $pingback_href_start;
         $pingback_server_url     = substr( $contents, $pingback_href_start, $pingback_server_url_len );
@@ -2809 +2809 @@
 
         if ( $pingback_server_url ) {
-            @ set_time_limit( 60 );
+            set_time_limit( 60 );
             // Now, the RPC call
             $pagelinkedfrom = get_permalink( $post );